Teach dreftool to recognize aliasing

RESOLVED INCOMPLETE

Status

Core Graveyard
Tracking
RESOLVED INCOMPLETE
14 years ago
a year ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

14 years ago
bug 8227 comment 51

false positive:
 920 aaronl    1.25	nsHTMLComboboxTextFieldAccessible* accessible = 
 921			  new nsHTMLComboboxTextFieldAccessible(this, mDOMNode,
mWeakShell);
 922 aaronl    1.31	*aFirstChild = accessible;
 923			if (! *aFirstChild)
 924 aaronl    1.24	  return NS_ERROR_FAILURE;
 925 aaronl    1.25	accessible->Init();


dreftool -H -D ../../../mozilla/accessible/src/html/nsHTMLSelectAccessible.cpp

Expected results:
Summary for ../../../mozilla/accessible/src/html/nsHTMLSelectAccessible.cpp: 
===============================
Files:  1
Lines:  ...
Errors: 0

Actual results:

mozilla/accessible/src/html/nsHTMLSelectAccessible.cpp:925 Deref-error: "accessible"
mozilla/accessible/src/html/nsHTMLSelectAccessible.cpp:973 Deref-error: "accessible"
mozilla/accessible/src/html/nsHTMLSelectAccessible.cpp:1233 Deref-error:
"accessible"

Reading the code one sees that the allocated object was aliased, and the alias
was null checked.
(Assignee)

Updated

14 years ago
Depends on: 8227

Comment 1

13 years ago
Sorry but for a foreseeable future I would like to focus on table bugs and dont
intend to work on this.
Assignee: bernd_mozilla → timeless

Comment 2

a year ago
Marking all tracking bugs which haven't been updated since 2014 as INCOMPLETE.
If this bug is still relevant, please reopen it and move it into a bugzilla component related to the work
being tracked. The Core: Tracking component will no longer be used.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.