225539 - In <bookmarksMenu.js>, "Error: aTarget has no properties"

Status: RESOLVED DUPLICATE of bug 416564

(SeaMonkey :: Bookmarks & History, defect)

Description

[HJ]

Error: aTarget has no properties
Source File: chrome://communicator/content/bookmarks/bookmarksMenu.js
Line: 652

Steps to reproduce: press Ctrl-Z

Comment 1

[Bryan]

Hi,
I noticed it in build Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) 
Gecko/20031112 also.

Comment 2

[Pierre Chanial]

HJ: is it a blocker for multizilla?

Comment 3

[HJ]

"HJ: is it a blocker for multizilla?"

No, not a real blocker, however, this is something I run into every hour or so.

Comment 4

[Asa Dotzler [:asa]]

How is this bug reproduced in SeaMonkey and what is the user impact?

Comment 5

[HJ]

"How is this bug reproduced in SeaMonkey"

Just use Ctrl+Z and that error will showup on your JS console. It is 100%
reproducable with mozilla 2003111415 on WinXP and NT4.

"...and what is the user impact?"

It has the potential of killing your bookmarks drag and drop feature...


note: I *always* verify my bug reports with a vanilla build, just to be sure :-)

Comment 6

[Bryan]

Hi,
It is reproduced by doing this
Source File: chrome://communicator/content/bookmarks/bookmarksMenu.js
Line: 652

It causes problems with bookmarks and the usability of them.

Comment 7

[Asa Dotzler [:asa]]

Not a blocker unless we can get actual reproducible symptoms (other than a js
console error). 

Comment 8

[Andreas Kunz]

With a current cvs build and a new, untouched profile, I get this error whenever
I open the bookmarks window.
It originates in
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarksTree.xml#645
and propagates through "BookmarksController.onCommandUpdate(selection, target);"
in the same file. "target" is null there.

Comment 9

[Andreas Kunz]

There is another similar error when doing drag and drop of a bookmark from the
bookmark manager to the personal toolbar with todays build and a new profile:

Error: aTarget has no properties
Source File: chrome://communicator/content/bookmarks/bookmarks.js
Line: 856

I'm not sure if they are related, but who knows...

Source is:
853     case "cmd_bm_newbookmark":
854     case "cmd_bm_newfolder":
855     case "cmd_bm_newseparator":
856       return BookmarksUtils.isValidTargetContainer(aTarget.parent);

Comment 10

[Andreas Kunz]

Sorry for messing with this bug, what I saw was not this bug, but bug 232827
(just filed after I discovered the difference).

Ctrl-Z is "undo" and this bug here only appears when there's nothing undoable
and the undo menu entry is inactive. This either means the shortcut is not
correctly inactivated or Ctrl-Z is also shortcut for a different command that
always fails, but that other one is not accessed as long as "undo" is possible.

doCommand("cmd_undo") calls onDragRemoveFeedBack in
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarksMenu.js#294
and that's where it fails.
I'm not sure why bookmarks get a "Undo" command there, but it seems like this
does not harm - undo fails where there's nothing to undo.

Comment 11

[Ray Booysen]

Reassigning as per Bug #32644

Comment 12

[HJ]

That bug is invalid so I'm undoing your changes.

Comment 13

[OstGote!]

comment 11 meant bug 326443

Comment 14

[Andrew Schultz]

duping to newer about-to-be-fixed bug