Closed
Bug 226249
Opened 22 years ago
Closed 22 years ago
buglist.cgi warning (use uninitialized value) line 97 for no ctype defined
Categories
(Bugzilla :: Query/Bug List, defect)
Bugzilla
Query/Bug List
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: goobix, Assigned: goobix)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
569 bytes,
patch
|
kiko
:
review+
|
Details | Diff | Splinter Review |
If we don't have a ctype CGI param defined, then I get in the server error log:
[Wed Nov 19 22:27:12 2003] [error] [client 127.0.0.1] stderr from script: [Wed
Nov 19 22:27:12 2003] buglist.cgi: Use of uninitialized value in string eq at
/var/www/html/bugzilla/buglist.cgi line 97.
Assignee | ||
Comment 1•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Attachment #135944 -
Flags: review?(AyukawaYukiko)
Assignee | ||
Updated•22 years ago
|
Attachment #135944 -
Flags: review?(AyukawaYukiko) → review?(kiko)
Assignee | ||
Comment 2•22 years ago
|
||
CC-ing default component owner and r? requstee.
Status: NEW → ASSIGNED
Comment 3•22 years ago
|
||
Comment on attachment 135944 [details] [diff] [review]
Patch
>Index: buglist.cgi
>-if ($::FORM{'ctype'} eq "js") {
>- Bugzilla->logout();
>+if (defined $::FORM{'ctype'}) {
>+ if ($::FORM{'ctype'} eq "js") {
>+ Bugzilla->logout();
There's this great operator -- && -- and it's very useful for cass like this
:-)
Attachment #135944 -
Flags: review?(kiko) → review-
Comment 4•22 years ago
|
||
*** Bug 226251 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 6•22 years ago
|
||
It can exists without being defined but as justdave and kiko enlighted me, it's
guaranteed to have a value in case it exists so using "exists" instead of
"defined" should work.
Attachment #135944 -
Attachment is obsolete: true
Assignee | ||
Updated•22 years ago
|
Attachment #135949 -
Attachment is obsolete: true
Assignee | ||
Comment 7•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Attachment #135950 -
Flags: review?(kiko)
Updated•22 years ago
|
Attachment #135950 -
Flags: review?(kiko) → review+
Assignee | ||
Updated•22 years ago
|
Flags: approval?
Comment 8•22 years ago
|
||
Oops. Sorry :-) But it did fix the security hole.
Gerv
Updated•22 years ago
|
Flags: approval? → approval+
Assignee | ||
Updated•22 years ago
|
Target Milestone: --- → Bugzilla 2.18
Assignee | ||
Comment 9•22 years ago
|
||
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi
new revision: 1.239; previous revision: 1.238
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
![]() |
||
Comment 10•20 years ago
|
||
*** Bug 235656 has been marked as a duplicate of this bug. ***
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•