226599 - Need Window icons for Microsoft Windows

Status: RESOLVED WORKSFORME

(Firefox :: General, defect, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Mozilla and Netscape 7 have window icons for things like bookmarks, etc. We need
them for Firebird for the following windows:

Browser
Bookmarks
Downloads
"Security UI" (generic icon for all Security windows)
Info windows (something with an "i" in it probably)
JavaScript console
Help
DOM Inspector
Venkman

some of these (DOMI, Venkman) can simply be pillaged from seamonkey. The others
will have to be done specifically for Firebird.

Comment 1

[Zack]

I really agree that Icons are needed, but there is a partial solution at
http://www.texturizer.net/firebird/tips.html#app_icon
however you will need to get your own icons, (you could use Mozilla's icons)
like I said, this is a partial solution, not even a true or complete workaround.
In Windows 98 and Windows me the only icon is the windows logo (in place of
nothing, becaus no icon was actually put in)

Comment 2

[Petr Baudis]

I think this should be given more priority - it is really kind of embarassing
when you show someone the shining browser and he immediatelly notices "Heh, but
it doesn't even have own icon!"

Firebird already puts its own small icon to the slit near Start, I think it has
the same dimensions...? And for most of the others, is there any problem with at
least just ripping these from Seamonkey for now?

Comment 3

[Alessandro Minelli]

Is there any relation with Bug 226602 ?

Comment 4

[Zack]

(In reply to comment #3)
> Is there any relation with Bug 226602 ?

I do not think so, but maybe there could be:
maybe when Firefox views those files (not through an HTML file, but the file
directly) they should use what ever icon someone made up for it (jpeg, png, mng,
etc.)

not that I have a clue how anyone would ever do that.... 

Comment 5

[Ali Ebrahim]

This is a minor polish bug. It certainly shouldn't block Firefox 0.9 which is a
feature-driven release. If it makes it in, great. If not, we shouldn't hold off
0.9 for this.

Comment 6

[Alex Brooks]

This DOES need to be sorted, preferably pre-0.9, but if not DEFINATLY befor 1.0.
 How a product looks is very imprortant... thunderbirds just got its own
identity compleatly sorted and Its only on 0.6

Comment 7

[Worcester12345]

(In reply to comment #6)
> This DOES need to be sorted, preferably pre-0.9, but if not DEFINATLY befor 1.0.
>  How a product looks is very imprortant... thunderbirds just got its own
> identity compleatly sorted and Its only on 0.6

I agree that it should get into at least the trunk for now, just so it gets on
the road to where it should be.

Comment 8

[Blake Ross]

Kevin, this isn't a big priority for 1.0. I'm not even convinced we need
separate window icons at all. 

Comment 9

[Kevin Gerich]

Blake, if this isn't necessary for 1.0, can we remove the blocking-aviary 1.0 +?

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Not a "blocker"

Comment 11

[George]

Attachment: Screenshot of Win98 problem

Here's a screenshot of task-bar problem in Windows 98. Any chance of a fix? It
really does not look very professional :-S

Comment 12

[Rev. Aaron D. Marasco]

(In reply to comment #11)
> Created an attachment (id=163610)
> Screenshot of Win98 problem

I just reinstalled FF 1.0 two times on my mom's Win98SE machine because of this
bug. It is not merely cosmetic - many experienced Windows users think of that
default icon as an indication that the application (or installer) has somehow
been corrupted.

I know nothing about Windows programming so don't know how it works fine on
WinXP. It is kinda shameful that the product deemed "1.0" doesn't have a working
icon on a still fairly major platform.

Comment 13

[Michael Wesoly]

I just installed Firefox on my parents computer on Win98 (first edition). The
window icon instead of the firefox logo made me somewhat insecure, if the
installation really worked. It looks terrible anyway.

I hope this is easy to fix. Please do it. It is a real show stopper, because it
looks somehow broken.

Comment 14

[Steve England [:stevee]]

requesting blocking as it's a silly bug, it's blatant to all win98 users, and
can probably be fixed relatively easily.

Comment 15

[Mike Connor [:mconnor]]

This is separate from the win98/gtk1 issues.  Those are covered by bug 171349. 
This is about separate icons for different windows, which isn't a blocker.

Comment 16

[Carlo 'Carcarlo' Carmagnini]

This bug has been fixed long ago. Tested FF 2.x on Win 98.

Comment 17

[José Jeria]

Based on above comment.