Closed Bug 226778 Opened 21 years ago Closed 21 years ago

Replace boolean flags in nsPresContext by state bits

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: smontagu, Assigned: smontagu)

References

Details

(Keywords: memory-footprint, perf)

Attachments

(1 file, 1 obsolete file)

Patch v.1
133.59 KB, patch
Details | Diff | Splinter Review
Spin off from thoughts in bug 166662 comment 9. There are a bunch of boolean flags in nsPresContext.h (PRPackedBools, not all consecutive) which I think would be better off as an array of state bits with inlined setters/getters.
Taking
Assignee: other → smontagu
Attached patch Patch v.0 (obsolete) — — Splinter Review
I don't see any obvious regressions here, but I haven't yet done a full smoketest.
Attached patch Patch v.1 — — Splinter Review
Corrected some errors that emerged in testing.
Attachment #136573 - Attachment is obsolete: true
bryner has done all this better elsewhere already.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: