226952 - Labels set/changed by filters are only stored in .msf file but not in X-Mozilla-Status2

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[Christian Eyrich]

Now that Bug 224519 is fixed setting labels also affects the X-Mozilla-Status2
field in the mail header. But unfortunately not always.
X-Mozilla-Status gets modified if the label is set by hand or by a filter when
the message arrives.

But it's not modified when running a filter on already existing messages ("Run
Now" button).

Comment 1

[David :Bienvenu]

I'll look at the filter case.

Comment 2

[Gregor Larson]

My be related to 234935 

Comment 3

[David :Bienvenu]

yes, you're right - this is a dup of bug 234935 - it works fine for me here,
except that I don't have non-local line terminators in my mail folders.

*** This bug has been marked as a duplicate of 234935 ***

Comment 4

[Christian Eyrich]

I'm not sure that's a dupe of bug 234935.
This here is about running filter after the fact doesn't update
X-Mozilla-Status2 at all (even if the mbox line endings are the local ones). Bug
234935 is about 
X-Mozilla-Status2 is never updated when having non-local line endings in the
mbox file.

That sounds different to me.

Comment 5

[David :Bienvenu]

ah, you're right. I see the problem and it's easy to fix. I'll attach a patch.

Comment 6

[David :Bienvenu]

Attachment: proposed fix

set the label through the db.

Comment 7

[David :Bienvenu]

correcting component

Comment 8

[Scott MacGregor]

Comment on attachment 145568 [details] [diff] [review]
proposed fix

this seems like a good 1.7 candidate

Comment 9

[David :Bienvenu]

Comment on attachment 145568 [details] [diff] [review]
proposed fix

this is a relatively minor bug, but the fix is very safe too.

Comment 10

[chris hofmann]

Comment on attachment 145568 [details] [diff] [review]
proposed fix

a=chofmann for 1.7

Comment 11

[David :Bienvenu]

fix checked in.

Comment 12

[Christian Eyrich]

Tested and verified. Thanks, David.