Closed Bug 226952 Opened 20 years ago Closed 20 years ago

Labels set/changed by filters are only stored in .msf file but not in X-Mozilla-Status2

Categories

(MailNews Core :: Filters, defect)

Product:
MailNews Core
Component:
Filters
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: ch.ey, Assigned: Bienvenu)

References

Details

Attachments

(1 file)

proposed fix
1.01 KB, patch
mscott
: superreview+
chofmann
: approval1.7+
Details | Diff | Splinter Review 
Now that Bug 224519 is fixed setting labels also affects the X-Mozilla-Status2
field in the mail header. But unfortunately not always.
X-Mozilla-Status gets modified if the label is set by hand or by a filter when
the message arrives.

But it's not modified when running a filter on already existing messages ("Run
Now" button).
I'll look at the filter case.
Status: NEW → ASSIGNED
My be related to 234935 
yes, you're right - this is a dup of bug 234935 - it works fine for me here,
except that I don't have non-local line terminators in my mail folders.

*** This bug has been marked as a duplicate of 234935 ***
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
I'm not sure that's a dupe of bug 234935.
This here is about running filter after the fact doesn't update
X-Mozilla-Status2 at all (even if the mbox line endings are the local ones). Bug
234935 is about 
X-Mozilla-Status2 is never updated when having non-local line endings in the
mbox file.

That sounds different to me.
ah, you're right. I see the problem and it's easy to fix. I'll attach a patch.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Attached patch proposed fix — — Splinter Review 
set the label through the db.
Attachment #145568 - Flags: superreview?(mscott)
correcting component
Component: Mail Database → Filters
Comment on attachment 145568 [details] [diff] [review]
proposed fix

this seems like a good 1.7 candidate
Attachment #145568 - Flags: superreview?(mscott) → superreview+
Comment on attachment 145568 [details] [diff] [review]
proposed fix

this is a relatively minor bug, but the fix is very safe too.
Attachment #145568 - Flags: approval1.7?
Comment on attachment 145568 [details] [diff] [review]
proposed fix

a=chofmann for 1.7
Attachment #145568 - Flags: approval1.7? → approval1.7+
fix checked in.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Tested and verified. Thanks, David.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.