Closed Bug 227896 Opened 21 years ago Closed 21 years ago

Composer build issues with Win32 & MinGW GCC

Categories

(SeaMonkey :: Build Config, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: d_king, Assigned: d_king)

References

Details

Attachments

(2 files, 2 obsolete files)

I have seen a couple of issues with building Composer on WIN32 with GCC, I will
be describing and attaching patches to this bug.
First problem is that NS_ALERTSERVICE_CONTRACTID is undefined in
mozilla/xpfe/components/build2/nsModule.cpp
Attached patch Patch for first problem (obsolete) — Splinter Review
Had to patch Makefile.in and add an include into nsModule.cpp
Second problem is about the infamous Win32 gcc call to ::main problem.
Depends on: 220978
Attached patch Patch for second problem (obsolete) — Splinter Review
The "normal" removal of the ::Main problem. Also, found that this bug is
dependant on an earlier fix (from cls) in bug #220978
Attachment #137093 - Flags: review?(bryner)
Well, the first patch fixed Composer/Sunbird, but Thunderbird wasn't happy with
it. This new patch works with both.
Attachment #137093 - Attachment is obsolete: true
Attachment #137093 - Flags: review?(bryner)
Comment on attachment 137173 [details] [diff] [review]
Second attempt at first problem

OK, lets see if this patch will pass a review?
Attachment #137173 - Flags: review?(bryner)
Hm, no, this isn't right.  We should switch the new-toolkit products to use the
alerts service in toolkit/components.  I see thunderbird is still using the one
from xpfe.  Scott, any thoughts?
For more information, which may not be relevant, may I suggest a quick look at
Bug #194315, and especially 

http://bugzilla.mozilla.org/show_bug.cgi?id=194315#c10

where it was decided to create the "build2" dir under XPFE for Minotaur sync
with the Trunk.
Comment on attachment 137173 [details] [diff] [review]
Second attempt at first problem

review request -> mscott, since he can better address  the questions here. 
Scott, please read comment 7 before reviewing this.
Attachment #137173 - Flags: review?(bryner) → review?(mscott)
Comment on attachment 137099 [details] [diff] [review]
Patch for second problem

Asking cls for a review of this patch as I copied it from one of his patches
and he knows GNU on WIN32 better than I do.
Attachment #137099 - Flags: review?(cls)
Attachment #137099 - Flags: review?(cls) → review+
Comment on attachment 137099 [details] [diff] [review]
Patch for second problem

Asking Brendan for an SR...keeping in mind that I have no checkin rights.
Attachment #137099 - Flags: superreview?(brendan)
Comment on attachment 137099 [details] [diff] [review]
Patch for second problem

You don't generally need sr for build changes, so if the module owner is ok,
and if you have no doubts about conventions to use (e.g., __GNUC__ not
defined), go for it.

Almost a matter of taste issue: maybe combine the #if{def,ndef} lines and
#endifs via #if defined XP_WIN && !defined __GNUC__ ?  A comment about MinGW
defining both would help the newcomers.

/be
Attachment #137099 - Flags: superreview?(brendan) → superreview+
Hmmm, I agree with the reformating of the IFDEF's. And I have added a comment
about why this is bad for MingW. New patch coming up once I've tested it...well,
at least made sure it compiles.

As for the SR, I always ask for them at the moment, as my Mozilla knowledge is
rather low. Once I gain more confidence, that will change.
Status: NEW → ASSIGNED
New patch as per comments from SR
Attachment #137099 - Attachment is obsolete: true
Comment on attachment 139704 [details] [diff] [review]
Final patch for second problem

Carrying over R and SR from prior patch as only minor chnages made.
Attachment #139704 - Flags: superreview+
Attachment #139704 - Flags: review+
Comment on attachment 139704 [details] [diff] [review]
Final patch for second problem

Patch for the second problem has been checked in.
Thanks cls, marking Fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
Comment on attachment 137173 [details] [diff] [review]
Second attempt at first problem

clearing old request
Attachment #137173 - Flags: review?(mscott)
V'ing
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: