Closed Bug 220978 Opened 21 years ago Closed 21 years ago

Composer Build error with GCC and WIN32


(SeaMonkey :: Composer, defect)

Windows XP
Not set


(Not tracked)



(Reporter: d_king, Assigned: d_king)




(1 file, 1 obsolete file)

This is the same as Bug #220433 (Firebird) and Bug #131479 (MingW) but for
standalone builds of Calendar (Sunbird).

The patch will be 99.9% identical to the one cls provided for Bug #220433.
Attached patch Patch using cls code (obsolete) — Splinter Review
I only had to patch splash.rc, as for some reason
mozilla/composer/app/nsComposerApp.cpp compiles fine without the changes.

Haven't tested, but I assume it's going to run fine.
Comment on attachment 132492 [details] [diff] [review]
Patch using cls code

A bit odd asking the original author to review his own code that I copied, but
such is life sometimes.
Attachment #132492 - Flags: first-review?(cls)
Comment on attachment 132492 [details] [diff] [review]
Patch using cls code

Egads.	How many copies of that splash.rc do we have?
Attachment #132492 - Flags: first-review?(cls) → first-review+
Thanks for the review.

I'm building Thunderbird now, so we'll see if I have to create another bug report.
Comment on attachment 132492 [details] [diff] [review]
Patch using cls code

Requesting a 'SR', unless there is someone else more suitable (remember, I
don't have CVS check-in rights, so whoever does the SR will probably get asked
to check in the patch).
Attachment #132492 - Flags: second-review?(mostafah)
Comment on attachment 132492 [details] [diff] [review]
Patch using cls code

I'm sorry I can't be of any use here. I don't build with gcc on windows so I
can't test this patch and neither do I have cvs access to that location. What
I'm wondering though is that what possible connection is there between the
splash.rc file in composer and calendar.
Hmmm, why did I select Calendar for this bug? Why does the summary say Calendar?

I must have been having a bad day....changing things to reality, which is
Composer. OK, so there isn't a seperate Composer Product, using Browser for now.
Component: Calendar General → Editor: Composer
Product: Calendar → Browser
Target Milestone: --- → mozilla1.6alpha
Version: unspecified → Trunk
QA Contact: brantgurganus2001 → petersen
Comment on attachment 132492 [details] [diff] [review]
Patch using cls code

Now that this bug is pointing at Composer rather than Calendar, asking Daniel
for a SR.
Attachment #132492 - Flags: superreview?(daniel)
Oh, and to answer the Thunderbird thing in comment #4, it builds fine.
Summary: Calendar Build error with GCC and WIN32 → Composer Build error with GCC and WIN32
Attached patch Missed a fileSplinter Review
Added module.rc in the same directory that needs the same fix.
Attachment #132492 - Attachment is obsolete: true
Comment on attachment 136262 [details] [diff] [review]
Missed a file

Same as original patch (which itself was a copy of a patch from cls), but
adding the same change to another file. This change got my Calender/Sunbird
build to finish sans errors.
Attachment #136262 - Flags: superreview?(daniel)
Attachment #136262 - Flags: review?(cls)
Attachment #136262 - Flags: review?(cls) → review+
Comment on attachment 136262 [details] [diff] [review]
Missed a file

I am not a super-reviewer. So I'm cancelling this request.
But you have my for this checkin. You can check this in
whenever you want. Thanks, David :-)
Attachment #136262 - Flags: superreview?(daniel) → superreview-
Sorry, I'm still getting used to sorting out who should do the SR.

Also, I don't have checkin privs, so maybe cls would like to do the honours for me?
Comment on attachment 136262 [details] [diff] [review]
Missed a file

Really, I suppose I should get a SR just to be complete.
Attachment #136262 - Flags: superreview- → superreview?(sfraser)
Blocks: 227896
Target Milestone: mozilla1.6alpha → mozilla1.7alpha
Attachment #136262 - Flags: superreview?(sfraser)
Patch has been checked in.
Closed: 21 years ago
Resolution: --- → FIXED
Attachment #132492 - Flags: superreview?(daniel)
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.