228603 - nsIWebBrowserPersist should have a saveChannel method

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

...looking something like this:
  void saveChannel(in nsIChannel aChannel, in nsIFile aTargetFile);

it would AsyncOpen the channel and save it to aTargetFile, similar to the
current saveURI.

Reason for this:
The current approach of having arguments for lots of stuff doesn't scale. if it
turns out a caller needs something else to set, it currently has to add a new
argument or is screwed.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

taking...

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[Adam Lock]

Comment on attachment 137725 [details] [diff] [review]
patch

r=adamlock except for the nsID for nsIWebBrowserPersist being changed. There is
no reason to change it.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

adam: I changed the IID because I was breaking binary compatibility... with the
changed IID, old callers of SaveDocument will fail to get the component, instead
of crashing calling the wrong function

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 137725 [details] [diff] [review]
patch

(marking r=adamlock)

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 137725 [details] [diff] [review]
patch

actually this is not enough... nsWebBrowser needs a change too

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2, also change nsWebBrowser

Comment 8

[Adam Lock]

Comment on attachment 139245 [details] [diff] [review]
patch v2, also change nsWebBrowser

r=adamlock

Comment 9

[Darin Fisher]

Comment on attachment 139245 [details] [diff] [review]
patch v2, also change nsWebBrowser

sr=darin

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in browser/webBrowser/nsWebBrowser.cpp;
/cvsroot/mozilla/embedding/browser/webBrowser/nsWebBrowser.cpp,v  <-- 
nsWebBrowser.cpp
new revision: 1.142; previous revision: 1.141
done
Checking in components/webbrowserpersist/public/nsIWebBrowserPersist.idl;
/cvsroot/mozilla/embedding/components/webbrowserpersist/public/nsIWebBrowserPersist.idl,v
 <--  nsIWebBrowserPersist.idl
new revision: 1.15; previous revision: 1.14
done
Checking in components/webbrowserpersist/src/nsWebBrowserPersist.cpp;
/cvsroot/mozilla/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp,v
 <--  nsWebBrowserPersist.cpp
new revision: 1.98; previous revision: 1.97
done
Checking in components/webbrowserpersist/src/nsWebBrowserPersist.h;
/cvsroot/mozilla/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.h,v
 <--  nsWebBrowserPersist.h
new revision: 1.26; previous revision: 1.25
done