228670 - update helper application pref dialog Help

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Michael Tosch]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.5) Gecko/20031112
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.5) Gecko/20031112

1.
In Mozilla Help -> Help Contents -> Search: spam, I find "controlling spam".
But it obviously finds nothing, i.e. it jumps to the beginning of chapter "Using
Mozilla Mail & Newsgroups".

2.
In Preferences, Helper Applications, click Help, I find:
    * Reset: Click this to clear any file-opening preferences you may have set
by unselecting the "Always ask before opening this type of file" checkbox in the
download dialog box.
But there is no Reset button (it has been removed in a previous Mozilla version).


Reproducible: Always

Steps to Reproduce:
1.
2.
3.



Expected Results:  
1.
Controlling spam section should be added;
a link to the mozilla.org anti-spam page would be fine.

2.
Compare and update the entire Helper Application section.


Probably the entire Help function hasnt been updated since Mozilla 1.0,
so any changes since are not reflected in Mozilla Help?

Comment 1

[Daniel Wang]

#1 is bug 196236

Comment 2

[R.J. Keller]

> 1.
> In Mozilla Help -> Help Contents -> Search: spam, I find "controlling spam".
> But it obviously finds nothing, i.e. it jumps to the beginning of chapter "Using
> Mozilla Mail & Newsgroups".

I don't see this.

> 2.
> In Preferences, Helper Applications, click Help, I find:
>     * Reset: Click this to clear any file-opening preferences you may have set
> by unselecting the "Always ask before opening this type of file" checkbox in 
> the
> download dialog box.
> But there is no Reset button (it has been removed in a previous Mozilla 
> version).

yeah, the prefs need updating. I have higher priority bugs, but if anyone would
like to contribute a fix for this, I would greatly appreciate it.

Comment 3

[Stefan [:stefanh]]

*** Bug 244734 has been marked as a duplicate of this bug. ***

Comment 4

[Werkstation beheer]

The helpfunction documentation should probably be updated for all OS's, we 
encountered the problem with a Linux implemantation.

Comment 5

[Stefan [:stefanh]]

Attachment: Update of cs_nav_prefs_navigator and nav_help

This will update the helper apps text in cs_nav_prefs_navigator and nav_help.
Hides/shows platform-specific content where possible (the Mozilla menu stuff
will be fixed in bug 256417) and adds <kbd> tags as well. This patch is also an
complete update of cs_nav_prefs_navigator, so it should fix some other bugs as
well.

Comment 6

[Stefan [:stefanh]]

Comment on attachment 156685 [details] [diff] [review]
Update of  cs_nav_prefs_navigator and nav_help

rlk, can you take a look?

Comment 7

[Stefan [:stefanh]]

Comment on attachment 156685 [details] [diff] [review]
Update of  cs_nav_prefs_navigator and nav_help

Hmm, I need to find out more about my mac Return key... Sorry for the spam -
clearing the review request.

Comment 8

[Stefan [:stefanh]]

Attachment: Slightly improved version

OK, this is basically the same patch as the previous one - just some minor
changes. I'll keep "Return" as the mac key for the win/*nix Enter key. The
Enter key on mac keyboards is the key at the very right of the numpad - a key
that you seldom use. However, both keys (Return and Enter) works the same on
the mac. The alternative is to describe both keys on the mac. But that is a
decision we can take later when all the files are fixed.

Comment 9

[Stefan [:stefanh]]

Attachment: better version, fixed some small errors

Comment 10

[Stefan [:stefanh]]

Comment on attachment 156987 [details] [diff] [review]
better version, fixed some small errors

OK, so I just fixed the ' and changed (in the decription of the download
dialog box in nav_help) "Open it with the default application</strong> (name of
application):" to "Open it with the default application (Application
Name)</strong>:" 

The set as default browser is a windows-only preference (I asked in
Mozillazine):

And the source:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/co
ntent/win/platformPrefOverlay.xul#61

Comment 11

[Stefan [:stefanh]]

Attachment: Even better patch

OK, after some more irc discussion with R.J. I changed the cache settings text
a bit. All OS:s now have "50 MB is sufficient".

Comment 12

[Stefan [:stefanh]]

--> Fixed

Comment 13

[Stefan [:stefanh]]

Oops...

Comment 14

[Daniel Wang]

verify fixed
Stefan, it appears that attachment 156991 [details] [diff] [review] is not the one checked in. Where is
the patch?

Comment 15

[Stefan [:stefanh]]

(In reply to comment #14)
> verify fixed
> Stefan, it appears that attachment 156991 [details] [diff] [review] is not the one checked in. Where is
> the patch?

The patch is attachment 156991 [details] [diff] [review]. I thought it got checked in. Looks like that
from the log. Do you mean that something else got checked in instead of
attachment 156991 [details] [diff] [review]?