228963 - history dropdown and dropmarker missing in url bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[José Jeria]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031218 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031218 Firebird/0.7+

The dropdown is missing in the url bar

Reproducible: Always

Steps to Reproduce:

Actual Results:  
Should be a dropdown so you can see visited sites.

Expected Results:  
No dropdown menu available.

Comment 1

[Mike Connor [:mconnor]]

ooh, that's bad.  This is absolutely a blocker.

Comment 2

[Keith]

wasn't this turned off purposely the other day?

Comment 3

[Mike Connor [:mconnor]]

it seems so:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=&branchtype=match&dir=mozilla%2Fbrowser+mozilla%2Ftoolkit&file=&filetype=match&who=&whotype=match&sortby=Date&hours=48&date=explicit&mindate=12%2F18%2F2003+16%3A46&maxdate=12%2F18%2F2003+16%3A48&cvsroot=%2Fcvsroot

waiting on an indication of why though.  If we ship with this it'll beat 210910
for dupes.

Comment 4

[Steffen Wilberg]

Maybe Ben removed it because of bug 192577 (URL bar drop-down does not collapse
on second click on down-arrow), which is now targetted for 0.9. I don't think
that bug is severe enough to remove the dropdown though.
-> Ben since he did it.

Comment 5

[Bill Gianopoulos [:WG9s]]

I agree with Steffen on this.  If this had been a new regression post 0.7, I
might view it differently, but since the 0.7 release exhibited the faulty
behaviour in the URL drop-down, I don't see the urgency to do something for 0.8.

It is more useful to have the URL drop-down there with it's little quirk than to
not have it at all.

It does not take too long for new users to figure out that clicking outside the
drop-down dismisses it.

It is also not obvious to new users that re-clicking the arrow is even supposed
to dismiss it anyway.  One would kind of think that if that were the case then,
when the drop down were present, the direction of the arrow would change to up
to indicate the change in action.

Comment 6

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6b) Gecko/20031217 Firebird/0.7+
(daihard; XFT+GTK2; optimized for P4/SSE-2)

http://bugzilla.mozilla.org/show_bug.cgi?id=192577 doesn't affect me in the
slightest.

Comment 7

[José Jeria]

*** Bug 229094 has been marked as a duplicate of this bug. ***

Comment 8

[Hussam Al-Tayeb]

One question. Since I'm using the 20031218 trunk build, I wanted to ask if this
bug is also found in the branch as well or only in the trunk. I'd appreciate it
if someone could answer me.

Comment 9

[Keith]

yes, its in the branch also.  Just to add to this, I understand the reason
behind the turning off of this, but bug 192577 seems to have been around since
february of this year, and we've had at least one milestone since (I don't
really feel like checking on the actual amount).  So why turn it off now?  The
only thing this will accomplish is frutrating users.

Comment 10

[alanjstr]

Well, unless we have a mindreader in here, we need to find Ben and ask what he
was thinking.

Comment 11

[Michael Lefevre]

Well I'm sure Ben will be found when he's at work.  What we need is for people
not to post large numbers of comments over the weekend before he's seen anything :)

Comment 12

[Haris Karahristianidis]

I think this is a 0.8 blocker. Most people need this feature. Noone will leave
IE when he sees that there is no URL dropdown

Comment 13

[Mike Connor [:mconnor]]

I wasn't supposed to set it to +, which is why I put it back to ?

You don't have authority to make it block the release, neither do I.  This was a
deliberate removal by ben and pch, and the development process is not a
democracy.  Please do not abuse your Bugzilla permissions.

Comment 14

[Haris Karahristianidis]

Sorry, I didn't know..

Comment 15

[Eddie]

This is definitely a blocker for me, I'll be going back to previous builds until
this doofus mistake has been corrected.

Comment 16

[David Tenser [:djst]]

If it's not a blocker, than a _really_ good reason why it was removed should be
presented. It sure makes using Mozilla Firebird harder, and without any real win
except 16px more horizontal screen estate for the address bar.

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

-> back in for now. 

Comment 18

[Hippo Man]

Back in where?  I just now did a checkout and a build off the main branch, and
it's not there.

Comment 19

[Michael Lefevre]

The change was checked into the 0.8 branch at 14:51 PST (when Ben added that
comment). The change was checked into the trunk at 16:22.

Comment 20

[Hippo Man]

That's the exact time of my previous message ... I missed it by a couple
minutes.  And yep, it's there now.  Thanks to Ben for putting it back in.

Comment 21

[Vedran Miletic]

>> back in _for now_

Why only for now?

Comment 22

[James Slaughter]

I'd love the drop-down to be optional, because I've never really understood the
point of it: it just seems to collect all the mistyped URL's I produce. Anything
I actually want to visit again will get into my Bookmarks, and I actually
appreciate the extra space that not having the dropdown affords because I keep
my address bar inline with the menu.

Comment 23

[alanjstr]

James:  you might want to look into
user_pref("browser.sessionhistory.max_entries", 20);

and

user_pref("browser.urlbar.autocomplete.learning.mode", 2);

Comment 24

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Removing self from CC list.