Closed Bug 229441 Opened 17 years ago Closed 16 years ago

Background images are not shown in Media tab (Page Info)

Categories

(Firefox :: Page Info Window, defect)

x86
Windows XP
defect
Not set
minor

Tracking

()

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: florian)

References

()

Details

(Keywords: fixed-aviary1.0, useless-UI)

Attachments

(1 file, 2 obsolete files)

The page info does not show any preview of background images in the Media tab
(page info). Clicking on the background images should show a preview in the
bottom of the dialog.

Steps to reproduce:
1. Go to http://www.zeldman.com
2. Go to the media tab in Page Info.
3. Click on any background image --> no preview is shown.
Branch build 20031223.
Also, clicking on the "Save as..." button does nothing (Bug 178469).
Keywords: useless-UI
Setting the "?" flag for 0.9 to get some attention. This and the actual
button(save as) are broken functionality in Firefox. 
Severity: normal → major
Flags: blocking0.9?
db48x, should we just be moving these to Browser->Page Info?

anyway, is this something there's a target timeframe for you fixing?
QA Contact: mconnor
Yea, it's something I have to look in to. At the moment, however, there's
something horribly wrong with my build (none of the trees anywhere in the
product work, so page info doesn't work at all), so I can't promise more than to
put it on the list.

As for the component, I can find stuff in either place. What is really needed
are two components, Browser:Page Info and Firefox:Page Info, that actually put
bugs in the same place. That'll probably never happen though :P

It would be really helpful if someone could check and see if this is a recent
regression, and if Mozilla has the same problem (probably does).
(In reply to comment #5)
No, i remember having this problem too with firefox0.8 final.
You can use View Background Image in the context menu if you really want this,
that's a simple workaround.  Severity -> minor

this isn't a blocker for 0.9, but a fix would be nice at some point before 1.0
Severity: major → minor
Flags: blocking0.9? → blocking0.9-
Flags: blocking1.0?
I also see this behavoir in my Mozilla 1.7 branch build 20040501 on Windows 98.
Would sure be very nice to get this fixed for the Mozilla 1.7 release, but thats
just a naive hint/wish from someone who only complains and never actively
develops anything ;-)
Flags: blocking1.0? → blocking1.0-
Since I also have this problem in Mozilla 1.7 branch on Windows 98, should't
Product (currently Firefox) and OS (currently Win XP) be changed, or should I
file a seperate bug for Mozilla?
Related to bug #96994 ?
Mozilla 1.7 has the same bug.
Attached patch This patch should fix this bug (obsolete) — Splinter Review
Firefox and Mozilla both have this bug. I think it isn't only with Windows XP.
This patch works for me. Seeking review.
Attachment #154449 - Flags: review?(db48x)
Attached patch minor change in the patch (obsolete) — Splinter Review
the minor change in this patch fix the display of icons and input images which
were having the same problem as background images.
Attachment #154449 - Attachment is obsolete: true
Attachment #154463 - Flags: review?(db48x)
Attachment #154449 - Flags: review?(db48x)
Comment on attachment 154463 [details] [diff] [review]
minor change in the patch

>+      newImage.width = ("width" in item && item.width) ? item.width : newImage.naturalWidth;
>+      newImage.height = ("height" in item && item.height) ? item.height : newImage.naturalHeight;

can be simplified to this:
+      newImage.width = ("width" in item && item.width) ||
newImage.naturalWidth;
+      newImage.height = ("height" in item && item.height) |
newImage.naturalHeight;

Also, the whole else clause is redundant and should be removed.

r=db48x with those changes
Attachment #154463 - Flags: review?(db48x) → review+
My bad, the else clause is only redundant if you consider the other changes I
have in my tree.
Comment on attachment 154463 [details] [diff] [review]
minor change in the patch

sr=jag, though I too prefer

newImage.width = "width" in item && item.width || newImage.naturalWidth;
Attachment #154463 - Flags: superreview+
Attached patch patchSplinter Review
changes done
Attachment #154463 - Attachment is obsolete: true
Fix checked in, thanks Florian.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Will this make it to the aviary branch as well?
(In reply to comment #7)
> this isn't a blocker for 0.9, but a fix would be nice at some point before 1.0

Now that there is a fix, requesting blocking-aviary1.0PR?

Flags: blocking-aviary1.0PR?
Attachment #154710 - Flags: approval-aviary?
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR-
Can someone edit this bug and move it to "Browser" "page info"?
The fix is checked in the trunk but it isn't in the aviary branch, still waiting
on approval...
Shouldn't this bug stay open until the fix is checked in the aviary branch?
It's rejected for Aviary by mconnor so I won't dare to change it
Does this fix inlude displaying the images referred by CSS?
Comment on attachment 154710 [details] [diff] [review]
patch

please don't request approval until you have a fully reviewed patch. thanks.
Attachment #154710 - Flags: approval-aviary?
(In reply to comment #24)
> (From update of attachment 154710 [details] [diff] [review])
> please don't request approval until you have a fully reviewed patch. thanks.
> 

The patch (attachment 154463 [details] [diff] [review]) is fully reviewed. The only change between
attachment 154463 [details] [diff] [review] and attachment 154710 [details] [diff] [review] is the change requested by
reviewer/superreviewer. attachment 154710 [details] [diff] [review] has been checked in the seamonkey
branch, why not request approval for Aviary since it's been fully reviewed and
checked in the other branch ?
there is a patch, it works on trunk, it is reviewed (see comment #25).
All ingredients Asa asked for.
Before this is forgotten forever, requesting ?1.0
Flags: blocking-aviary1.0- → blocking-aviary1.0?
Attachment #154710 - Flags: approval-aviary?
its still not a blocker.  If it gets approved and someone checks it in, great,
but its not something we can't ship without.

Please don't use the blocking flags as attention-getters.
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Comment on attachment 154710 [details] [diff] [review]
patch

a=asa for aviary checkin.
Attachment #154710 - Flags: approval-aviary? → approval-aviary+
Fix checked in on aviary branch
Keywords: fixed-aviary1.0
*** Bug 96994 has been marked as a duplicate of this bug. ***
Component: General → Page Info
QA Contact: mconnor → firefox.page-info
Verified fixed.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091204 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20091204044732
Status: RESOLVED → VERIFIED
Assignee: bugzilla → florian
You need to log in before you can comment on or make changes to this bug.