178469 - Saving of background images from Page Info does not work.

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Jason Bassford]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021105
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021105

Carry over from bug 176733 which has been marked FIXED.  (This is a specific
instance of a problem from there.)

HTML based background images cannot be saved via Page Info / Media.  (All
other images can.)

See:

http://www.mozillazine.org/talkback/read.php?f=4&i=4543&t=4536
http://www.mozillazine.org/talkback/read.php?f=4&i=4548&t=4536

Reproducible: Always

Steps to Reproduce:
1. Go to the target URL.
2. Right-click on the page and select View Page Info.
3. Click on the Media tab.
4. With the first entry, "tile_gif.gif" highlighted, click on Save As.

Actual Results:  
Nothing happens.

Expected Results:  
A download dialogue should have appeared.

This only happens with HTML based background images.

Comment 1

[Jean-Pierre Melkonian]

Same on Mac OS 9.1, Build 2002110408

Comment 2

[Antonio Flores]

Same things happens with every webpage that I've visited while using Mozilla
1.4a today. Odd thing is that I was able to download images a few days ago with
no problems and the download manager always came up. Today, whenever I right
click to "save image as" or a link to save a image file to my hard drive, I
either get that my system can't save the image that it's looking for due to an
error with the cached memory or nothing happens.

TonyX

Comment 3

[Antonio Flores]

Sorry, I forgot to mention that the same bug/problem occurs while using Mozilla
1.4a for Windows XP and Red Hat Linux 7.2 (kernel 2.4.20).

Comment 4

[Antonio Flores]

After debating whether or not this issue will or will not be fixed and finding
out that it not only applies to images, but to nearly any document that is to be
saved; I've decided to downgrade to Mozilla 1.3 as the problem does not seem to
show up there. Sorry.

Comment 5

[Jason Bassford]

Changing reference URL since old one no longer exists.  Note that step 4 in
"Steps to Reproduce" should now read "With the second entry, 'tile_gif.gif'
highlighted, click on Save As."

Comment 6

[José Jeria]

*** Bug 219492 has been marked as a duplicate of this bug. ***

Comment 7

[Christopher Nehren]

I can reproduce this with Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7a)
Gecko/20040307 and Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6)
Gecko/20040302 Firefox/0.8. Commenting because of the last non-dup comment's age.

Comment 8

[Asa Dotzler [:asa]]

Not going to block for this. A well tested and fully reviewed patch would be
considered for final. 

Comment 9

[Mike Connor [:mconnor]]

*** Bug 239375 has been marked as a duplicate of this bug. ***

Comment 10

[OstGote!]

At the moment nothing works there ... see Bug 239472.

Comment 11

[R.K.Aa.]

*** Bug 247860 has been marked as a duplicate of this bug. ***

Comment 12

[Blake Ross]

Not blocking 1.0 but would be /really/ nice (and not hard, right?) to get a
patch for this, since it's essentially non-working UI.

Comment 13

[Florian Quèze [:florian]]

Attachment: patch

Comment 14

[Peter van der Woude [:Peter6]]

Firefox specific ?

Now that bug 229441 - Background images are not shown in Media tab (Page Info)

has been fixed it would be nice to see this one fixed too

Comment 15

[José Jeria]

There is a patch, but daniel brooks is asked to review. Is this correct?

Comment 16

[Daniel Brooks [:db48x]]

Comment on attachment 154876 [details] [diff] [review]
patch

r=db48x
Sorry it took so long, I'd forgotten about it.

Comment 17

[Ryan Polk (Quark)]

Comment on attachment 154876 [details] [diff] [review]
patch

Bad UI and a reviewed patch, can this get on the train?

Comment 18

[Ryan Polk (Quark)]

Comment on attachment 154876 [details] [diff] [review]
patch

Removing approval request.  The patch in bug 239472 seems to include this patch
among other fixes.

Comment 19

[Florian Quèze [:florian]]

*** Bug 260815 has been marked as a duplicate of this bug. ***

Comment 20

[José Jeria]

Isnt this then a duplicate of bug 239472?

Comment 21

[Jason Bassford]

If they are the same, it would be more accurate to say that bug 239472 is the
duplicate.  This one was filed much earlier, also has a patch submitted for
review, and has more votes.

However, if you look at the summary of bug 239472 it's specific Steps to
Reproduce *excludes* the specific case that this bug is targetting.

So, no, there is no direct duplication.

Comment 22

[Jason Bassford]

(However, it appears as if the patch proposed in bug 239472 might fix this bug
also...)

Comment 23

[Florian Quèze [:florian]]

Basicaly, bug 239472 was a regression after the check in of a patch from bug
196971. Bug 239472 was only for Seamonkey. The patch I attached to bug 239472
make page info (in both Seamonkey and Firefox) send referrer when saving media.
I included in this patch the fix for saving of background images. So this bug
isn't a duplicate, but the patch for bug 239472 will fix this bug too.

Comment 24

[Worcester12345]

Can we get a milestone set on this bug, so we have something to look forward to?

Comment 25

[Florian Quèze [:florian]]

Patch 162252 from bug 239472 has been checked in, so this bug is fixed.