Basic table layout strategy could be more depres(s)ed

RESOLVED FIXED

Status

()

RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: bernd_mozilla, Assigned: bernd_mozilla)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
the following build warning 
In file included from
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/layout/html/table/src/FixedTableLayoutStrategy.cpp:38:
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/layout/html/table/src/BasicTableLayoutStrategy.h:99:
warning: `virtual nscoord
BasicTableLayoutStrategy::CalcPctAdjTableWidth(nsIPresContext&, const
nsHTMLReflowState&, int, float)' was hidden
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/layout/html/table/src/FixedTableLayoutStrategy.h:86:
warning:   by `virtual nscoord
FixedTableLayoutStrategy::CalcPctAdjTableWidth(const nsHTMLReflowState&, int,
float)'

makes me ask why we need there a PresContext.
(Assignee)

Comment 1

15 years ago
Created attachment 137996 [details] [diff] [review]
patch
(Assignee)

Comment 2

15 years ago
Comment on attachment 137996 [details] [diff] [review]
patch

roc thats the issue we talked about on irc.
Attachment #137996 - Flags: superreview?(roc)
Attachment #137996 - Flags: review?(roc)
-  if (mTableFrame->IsBorderCollapse()) {

Can you explain why you are you making this code unconditional?

+    nsMargin childAreaOffset = GetChildAreaOffset( &aReflowState);

Lose the extra space

looks good...
Attachment #137996 - Flags: superreview?(roc)
Attachment #137996 - Flags: superreview+
Attachment #137996 - Flags: review?(roc)
Attachment #137996 - Flags: review+
(Assignee)

Comment 5

15 years ago
fix checked in the page load time did more increase than decrease but the
footprint shrinked by 100 bytes, what a gain :-(
(Assignee)

Updated

15 years ago
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Blocks: 229631
You need to log in before you can comment on or make changes to this bug.