229457 - Basic table layout strategy could be more depres(s)ed

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Bernd]

the following build warning 
In file included from
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/layout/html/table/src/FixedTableLayoutStrategy.cpp:38:
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/layout/html/table/src/BasicTableLayoutStrategy.h:99:
warning: `virtual nscoord
BasicTableLayoutStrategy::CalcPctAdjTableWidth(nsIPresContext&, const
nsHTMLReflowState&, int, float)' was hidden
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/layout/html/table/src/FixedTableLayoutStrategy.h:86:
warning:   by `virtual nscoord
FixedTableLayoutStrategy::CalcPctAdjTableWidth(const nsHTMLReflowState&, int,
float)'

makes me ask why we need there a PresContext.

Comment 1

[Bernd]

Attachment: patch

Comment 2

[Bernd]

Comment on attachment 137996 [details] [diff] [review]
patch

roc thats the issue we talked about on irc.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

-  if (mTableFrame->IsBorderCollapse()) {

Can you explain why you are you making this code unconditional?

+    nsMargin childAreaOffset = GetChildAreaOffset( &aReflowState);

Lose the extra space

looks good...

Comment 4

[Bernd]

I believe the code at
http://lxr.mozilla.org/seamonkey/source/layout/html/table/src/BasicTableLayoutStrategy.cpp#221
and
http://lxr.mozilla.org/seamonkey/source/layout/html/table/src/nsTableFrame.cpp#2835
is redundant.

Comment 5

[Bernd]

fix checked in the page load time did more increase than decrease but the
footprint shrinked by 100 bytes, what a gain :-(