Closed Bug 229631 Opened 16 years ago Closed 16 years ago

<FixedTableLayoutStrategy.h>: Fix 2 new "... was hidden by ..." 'Build Warnings'

Categories

(Core :: Layout: Tables, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: sgautherie, Assigned: bernd_mozilla)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

I believe this check-in:
{
12/28/2003 09:02	bmlk%gmx.de

reduce prescontext usage in basic layout strategy bug 229457 r/sr=roc
}
caused these warnings to appear
{
karnaze

1-2.	layout/html/table/src/FixedTableLayoutStrategy.h:103 (See 1st of 2 warnings
in build log)
	...was hidden by `virtual PRBool
FixedTableLayoutStrategy::AssignNonPctColumnWidths(nsIPresContext*, int, const
nsHTMLReflowState&, float)'

101 nscoord                  aComputedWidth,
102 const nsHTMLReflowState& aReflowState,
103 float                    aPixelToTwips);


3-4.	layout/html/table/src/FixedTableLayoutStrategy.h:84 (See 1st of 2 warnings
in build log)
	...was hidden by `virtual nscoord
FixedTableLayoutStrategy::CalcPctAdjTableWidth(const nsHTMLReflowState&, int,
float)'

82   virtual nscoord CalcPctAdjTableWidth(const nsHTMLReflowState& aReflowState,
83                                        nscoord                  aAvailWidth,
84                                        float                   
aPixelToTwips) {return 0;};
85 
86 protected:
}

Can they be fixed ?
Severity: major → normal
Assignee: table → bernd_mozilla
Attached patch patch [Checked in: Comment 3] (obsolete) — Splinter Review
Attachment #138110 - Flags: superreview?(roc)
Attachment #138110 - Flags: review?(roc)
Attachment #138110 - Flags: superreview?(roc)
Attachment #138110 - Flags: superreview+
Attachment #138110 - Flags: review?(roc)
Attachment #138110 - Flags: review+
fix checked in
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment on attachment 138110 [details] [diff] [review]
patch
[Checked in: Comment 3]


Check in: { 12/29/2003 08:58	bmlk%gmx.de }

Thanks for this fast work :-)
Attachment #138110 - Attachment description: patch → patch [Checked in: Comment 2]
Attachment #138110 - Attachment is obsolete: true
Attachment #138110 - Attachment description: patch [Checked in: Comment 2] → patch [Checked in: Comment 3]
Target Milestone: --- → mozilla1.7alpha
You need to log in before you can comment on or make changes to this bug.