Closed Bug 229603 Opened 17 years ago Closed 15 years ago

nsViewBeOS inheritance

Categories

(Core Graveyard :: Widget: BeOS, defect)

x86
BeOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sergei_d, Assigned: sergei_d)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

4.71 KB, patch
thesuckiestemail
: review+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review
nsViewBeOS call in
mozilla/widget/src/beos/nsWindow.h
is inherited from both BView and nsIWidgetStore,
but object which uses this class is declared in sme header file as
BView *mView;
which causes several casts and additional methods like
BView  *CreateBeOSView();
Wondering why not to use just nsViewBeOS instead BView, and thus to have not
only direct access to cached mWidget, but also to cache nsToolkit - see bug
http://bugzilla.mozilla.org/show_bug.cgi?id=226889
Not an _XP_ widgets issue.... that component is for cross-platform widgets.
Assignee: jag → arougthopher
Component: XP Toolkit/Widgets → GFX: BeOS
QA Contact: jrgmorrison → timeless
bz, do components in mozilla/widget really belong to GFX:*  ?
sergei: they don't, but they're labeled beos. in the future there may be a
widget: beos. in the meantime, just live with the slight misnomer. it's much
easier for me and everyone else to send port bugs here.
Time to fix that, it seems, as we started to use more and more nsViewBeOS methods 
 
Assignee: beos → sergei_d
Component: GFX: BeOS → Widget: BeOS
Attached patch patch.Splinter Review
review request
Attachment #201998 - Flags: review?
Attachment #201998 - Flags: review? → review?(thesuckiestemail)
Comment on attachment 201998 [details] [diff] [review]
patch.

r=thesuckiestemail@yahoo.se
(It seems I do more reviewing than coding :)
Attachment #201998 - Flags: review?(thesuckiestemail) → review+
checked in trunk:
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.108; previous revision: 1.107
done
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.45; previous revision: 1.44
done.

Attention to Nielx - further changes may depend on that, so it is good to fix it at branch too at some moment
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
I'll keep track of it.
Whiteboard: Needs backporting to MOZILLA_1_8_BRANCH
Will be backported to the MoZILLA_1_8_BRANCH
Blocks: 311032
Comment on attachment 201998 [details] [diff] [review]
patch.

Requesting approval for the MOZILLA_1_8_BRANCH.

This is a BeOS-only change and will not affect any other platforms.

Note to sergei_d: apply after bug 315208
Attachment #201998 - Flags: approval1.8.1?
Attachment #201998 - Flags: approval1.8.1? → approval1.8.1+
Enter passphrase for key '/boot/home/.ssh/id_dsa':
Checking in mozilla/widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.16; previous revision: 1.91.4.15
done
Checking in mozilla/widget/src/beos/nsWindow.h;
/cvsroot/mozilla/widget/src/beos/nsWindow.h,v  <--  nsWindow.h
new revision: 1.35.4.11; previous revision: 1.35.4.10
done 
Keywords: fixed1.8.1
Whiteboard: Needs backporting to MOZILLA_1_8_BRANCH
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.