229879 - Thunderbird does not properly display attachments sent from a mac

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Nick Bebout]

Dave sent me a file and all it shows in attachments is one file called % 

He said that it should show that, along with another file, like it does when I
view the same message in Outlook Express.

Comment 1

[Dave Miller [:justdave]]

The file I sent nb was encapsulated in AppleDouble format, which is explained
here:  http://www.ietf.org/rfc/rfc1740.txt

Most non-Mac user agents which are not AppleDouble-aware will display both parts
as separate attached files, of which you just discard the one with the % at the
beginning of the filename.  Non-Mac user agents which *are* AppleDouble-aware
will usually display only the data fork (i.e. the actual file) and automatically
discard the metadata/resource fork half for you.  From what nb described to me
about what he got, I suspect Thunderbird is trying to be AppleDouble-aware and
discarding the wrong half.

Comment 2

[Dave Miller [:justdave]]

Actually, I take that back...  he did say it identified the mime type as
multipart/appledouble, which means it didn't take the pieces apart.

Comment 3

[WADA:World Anti-bad-Duping Agency]

Problem in creation of multipart/appledouble when mail.file_attach_binary=true
seems to be resolved by Thunderbird 2003-12-10, but problem in disply does not
seem to be resolved yet.
This was reported in a Mozillazine forum. 
See http://forums.mozillazine.org/viewtopic.php?t=39285&highlight=appledouble

Comment 4

[WADA:World Anti-bad-Duping Agency]

Same as Mozilla Mail&News Bug 229855 ?
>check filename extension before Appledouble-encoding attachment having
insignificant resource fork

Comment 5

[WADA:World Anti-bad-Duping Agency]

Bug 229855 was different problem - problem of AppleDouble attachment creation
when not necessary.
Sorry for spam.

Comment 6

[HARUNAGA Hirotoshi]

Mozilla Mail issue is Bug 208196.

Comment 7

[Scott MacGregor]

anyone have a message they can send me that demonstrates this problem?

i.e. I can try to read the message on my windows debug build and see us pick the
wrong fork.

If someone can get me a test case today, there is a chance a quick fix could
make the thunderbird 0.5 train.

Comment 8

[Dave Miller [:justdave]]

Sent.

Comment 9

[Scott MacGregor]

Attachment: the fix (always look in the 2nd part first for the file name)

for apple/double files, always extract the file name by looking at the second
part and if it does not have a file name, then look in the first part.

The second part is the data fork and the first part is the resource fork

Comment 10

[Scott MacGregor]

one weird thing that is unrelated to this fix. When you try to open one of these
attachments (by double clicking it), the helper app dialog lists the content
type as apple double and does not know what to do with it. I thought we used to
extract the data fork automatically.

Comment 11

[Scott MacGregor]

fix checked into the M4 branch and the trunk.

Comment 12

[WADA:World Anti-bad-Duping Agency]

Since resource folk(application/applefile part) is usually placed as first part
in appledouble, your logic is expected to work well.
However, MIME specification for appledouble deos not define part sequence of
resorce falk part and data folk part.
Therefore, I belive logic should be "part other than application/applefile is
data folk".
Scott, what do you think?

Comment 13

[Scott MacGregor]

WADA, you are probably right, we should check the content type of each part and
use the part that is not the applefile part. Let's fix it that way on the trunk.
I'd rather not risk 0.5 for such a change anymore.