Closed Bug 230211 Opened 21 years ago Closed 20 years ago

Downloading of LDAP directory for offline access broken


(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Windows 2000
Not set


(Not tracked)



(Reporter: david_thatcher, Assigned: Bienvenu)



(Keywords: topcrash)


(1 file, 1 obsolete file)

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: Mozilla Thunderbird 0.5a (20040105)

Running Thunderbird checking mail on a communigate server which also hosts an 
LDAP directory. I know that Thunderbird is able to talk to the LDAP server 
because auto-fill works fine. However, when I go and choose to download the 
LDAP directory and then go into the address book, the LDAP directory shows 0 

Reproducible: Always

Steps to Reproduce:
1.Go to properties for LDAP directory
2.Choose Offline tab then Download Now.
3.Hit OK and return to address book

Actual Results:  
Lack of entries(0 cards) for LDAP directory

Expected Results:  
Display contents of LDAP directory per set filter (in my case, all records).

Categorizing as major since availability of offline LDAP directory is essential 
for mobile users, especially in a corporate environment.
For me, at step three, moz crashes.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040312
I have a fix for the crash but not the replication failing. Did this ever work
in thunderbird? Do you have a test ldap server I could try this against?
Assignee: mscott → bienvenu
Ever confirmed: true
Attached patch fix for crash (obsolete) — Splinter Review
this will fix the crash. The alternative fix is to make GetMessageListener
return an error when there's no listener.
Attachment #144508 - Flags: review?(dmose)
turns out this was a problem in the address book replication code - it was
re-using ldap operation objects, a bozo no-no, according to dmose. This fixes
the address book code to create new ldap operations for new ldap operations.

Also, I found out that ldap replication is working, with this patch, if your
server is set up to allow returning at least as many entries as are in the
directory, or if you set up your filter to limit the query in such a way that
less than the limit of entries the server will return (e.g.,
(&(objectclass=*)(cn=Ada*)). By default, many servers limit the number of
entries that will get returned - e.g., OpenLDAP limits it to 500. Also, the
admin user is often allowed to get all the entries...
Attachment #144508 - Attachment is obsolete: true
Attachment #144581 - Flags: superreview?(mscott)
changing product to mailnews
Product: Thunderbird → MailNews
Version: unspecified → Trunk
Comment on attachment 144581 [details] [diff] [review]
fix to replication code

this code change is only in ldap replication, which was crashing anyway...
Attachment #144581 - Flags: approval1.7?
Keywords: topcrash
Comment on attachment 144581 [details] [diff] [review]
fix to replication code

clearing until review.
Attachment #144581 - Flags: approval1.7?
Attachment #144581 - Flags: superreview?(mscott) → superreview+
Comment on attachment 144581 [details] [diff] [review]
fix to replication code

this is a safe fix - it only affects the ldap replication code, and creates a
new ldap operation instead of using the old ldap operation.
Attachment #144581 - Flags: approval1.7?
Comment on attachment 144581 [details] [diff] [review]
fix to replication code

a=chofmann for 1.7
Attachment #144581 - Flags: approval1.7? → approval1.7+
fix checked in.
Closed: 20 years ago
Resolution: --- → FIXED
Blocks: 238446
Comment on attachment 144508 [details] [diff] [review]
fix for crash

Attachment #144508 - Flags: superreview+
Attachment #144508 - Flags: review+
Comment on attachment 144508 [details] [diff] [review]
fix for crash

clearing requests
Attachment #144508 - Flags: superreview+
Attachment #144508 - Flags: review+
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.