230211 - Downloading of LDAP directory for offline access broken

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[david_thatcher]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: Mozilla Thunderbird 0.5a (20040105)

Running Thunderbird checking mail on a communigate server which also hosts an 
LDAP directory. I know that Thunderbird is able to talk to the LDAP server 
because auto-fill works fine. However, when I go and choose to download the 
LDAP directory and then go into the address book, the LDAP directory shows 0 
cards.

Reproducible: Always

Steps to Reproduce:
1.Go to properties for LDAP directory
2.Choose Offline tab then Download Now.
3.Hit OK and return to address book


Actual Results:  
Lack of entries(0 cards) for LDAP directory

Expected Results:  
Display contents of LDAP directory per set filter (in my case, all records).

Categorizing as major since availability of offline LDAP directory is essential 
for mobile users, especially in a corporate environment.

Comment 1

[james davis]

For me, at step three, moz crashes.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040312

Comment 2

[David :Bienvenu]

I have a fix for the crash but not the replication failing. Did this ever work
in thunderbird? Do you have a test ldap server I could try this against?

Comment 3

[David :Bienvenu]

Attachment: fix for crash

this will fix the crash. The alternative fix is to make GetMessageListener
return an error when there's no listener.

Comment 4

[David :Bienvenu]

Attachment: fix to replication code

turns out this was a problem in the address book replication code - it was
re-using ldap operation objects, a bozo no-no, according to dmose. This fixes
the address book code to create new ldap operations for new ldap operations.

Also, I found out that ldap replication is working, with this patch, if your
server is set up to allow returning at least as many entries as are in the
directory, or if you set up your filter to limit the query in such a way that
less than the limit of entries the server will return (e.g.,
(&(objectclass=*)(cn=Ada*)). By default, many servers limit the number of
entries that will get returned - e.g., OpenLDAP limits it to 500. Also, the
admin user is often allowed to get all the entries...

Comment 5

[David :Bienvenu]

changing product to mailnews

Comment 6

[David :Bienvenu]

Comment on attachment 144581 [details] [diff] [review]
fix to replication code

this code change is only in ldap replication, which was crashing anyway...

Comment 7

[David :Bienvenu]

Comment on attachment 144581 [details] [diff] [review]
fix to replication code

clearing until review.

Comment 8

[David :Bienvenu]

Comment on attachment 144581 [details] [diff] [review]
fix to replication code

this is a safe fix - it only affects the ldap replication code, and creates a
new ldap operation instead of using the old ldap operation.

Comment 9

[chris hofmann]

Comment on attachment 144581 [details] [diff] [review]
fix to replication code

a=chofmann for 1.7

Comment 10

[David :Bienvenu]

fix checked in.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 144508 [details] [diff] [review]
fix for crash

r+sr=dmose

Comment 12

[David :Bienvenu]

Comment on attachment 144508 [details] [diff] [review]
fix for crash

clearing requests