23083 - HTML source display window responds incorretly the encoding switching

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect, P3)

Description

[Jungshik Shin]

This bug is related to the bug 12502, but is a separate problem.
When I change the encoding in the page source display window
using View|Character Set menu, the page source display window
interpretes HTML and renders the page in question as a web page
instead of displaying the HTML source in the encoding specified
via View|Character Set menu.

Comment 1

[Katsuhiko Momoi]

Do we need a charset menu in the View | Source window?
I really thik we should settle this question first.

Comment 2

[Frank Tang]

Move to M14

Comment 3

[Frank Tang]

Change the platform and OS to ALL

Comment 4

[Frank Tang]

reassign to jbetak since I also ask him to take a look at view source issue.

Comment 5

[[e-mail] (away - not reading bugmail)]

This should be fully addressed by the fixes I have working in my private tree. 
I will check them in on Sunday or Monday (02/14) - code review permitting.

I made the view-source attribute sticky, so a webshell cannot return to the 
HTML browsing state, once it's been used for viewing the source of a web 
page.

Also, the attribute is now set whenever a URL is loaded instead of doing it 
in DocumentReload, which allows us to display the source of web pages 
without the charset meta tag.

The only open point about this problem is, whether a webshell should be 
used for normal browsing, once the source view is not needed anymore. This 
could be done by looking at the DTD Document attributes, if deemed 
useful. Tentative target: after Beta1.

Comment 6

[Frank Tang]

reopen bugs which have NOT YET FIXED yet.  

Comment 7

[[e-mail] (away - not reading bugmail)]

Ok, next attemot to close this bug. The code changes are finally in. They should be in the nightly build on Feb 23.

Comment 8

[Jungshik Shin]

I tried the newest nightly build(March 1st) and seems like
everything works fine.