Closed
Bug 231361
Opened 21 years ago
Closed 20 years ago
download manager doesn't show downloaded filesize after 1MB if the filesize is "unknown"
Categories
(Toolkit :: Downloads API, defect, P4)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bisi, Assigned: bugs)
References
()
Details
(Keywords: fixed-aviary1.0)
Attachments
(5 files, 5 obsolete files)
5.67 KB,
image/png
|
Details | |
5.82 KB,
image/png
|
Details | |
5.19 KB,
patch
|
bugs
:
review+
bugs
:
approval-aviary+
|
Details | Diff | Splinter Review |
8.05 KB,
image/png
|
Details | |
1.49 KB,
patch
|
bugs
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7a) Gecko/20040115 Firebird/0.8.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7a) Gecko/20040115 Firebird/0.8.0+ For example, PHPmyadmin offers exporting of the database-files and after choosing some properties the file begins to download, which actually has an "unknown" size. MozillaFirebird shows the correct size till the downloaded size reaches 1MB and then the text showing the downloaded filesize disappears (there's only: at [speed], ??? remain). Nevertheless the download finishes as expected and everything is OK with the downloaded file. Reproducible: Always Steps to Reproduce: 1. download a file with an "unknown" filesize 2. wait till the downloaded filesize reaches 1MB 3. the downloaded filesize disappears Actual Results: MozillaFirebird doesn't show the downloaded filesize after 1MB. Expected Results: MozillaFirebird should show the downloaded filesize after 1MB.
Reporter | ||
Updated•21 years ago
|
Severity: minor → normal
Comment 1•21 years ago
|
||
WFM, using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20040102 Firebird/0.7+ I tried to download: ftp://ftp.mozilla.org/pub/mozilla.org/firebird/nightly/latest-0.8/FirebirdSetup.exe I watched the filesize reach 2MB/6MB no problem. Žiga, can you post the URL you are having problems with to help further debug your problem?
Reporter | ||
Comment 2•21 years ago
|
||
Reporter | ||
Comment 3•21 years ago
|
||
Reporter | ||
Comment 4•21 years ago
|
||
Yes, but the given Firebirdsetup.exe file has a known file size (ca. 6,4MB). I have uploaded two files, which should show, what I mean. Unfortunately I can't give you access to my phpmyadmin, because it's password-protected for security reasons. I'll try to find a "public" webpage, which generates files with unknown file size.
Right. Reproduced on trunk.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 6•21 years ago
|
||
noririty - can you add the URL you used to reproduce the bug to the ticket please - it will help others to reproduce the bug, and the confirm it is working when it is fixed.
I'm sorry but I can't. I used the password protected test case uri given by reporter to reproduce this bug. So we need to find other test case out. -> qawanted (test case needed) Oh, and I also tested on 0.7 but download progress dialogbox and download sidebar doesn't have this problem.
Keywords: qawanted
Whiteboard: test case needed
Reporter | ||
Updated•21 years ago
|
Reporter | ||
Comment 8•21 years ago
|
||
I have just attached an URL, which shows the bug. Click on the link "LINK" and firebird will start downloading a 3,82MB big mpeg file (blackhumor.mpeg ;)). (behind the download.htm file there is, as you might see, a file called download_mpeg.php, which "gives" the order to download blackhumor.mpeg")
Comment 9•21 years ago
|
||
I get this bug with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040115 Firebird/0.8.0+
Comment 10•21 years ago
|
||
The example file is causing the code to hit the undefined state in DownloadProgressListener._formatKBytes in DownloadProgressListener.js. Just adding another clause to the if/elseif block to deal with this situation seems to work OK, i.e. something like: else if (progressHasMB && !totalHasMB) { // Download progress is > 1MB but filesize is unknown format = this._statusFormatMBMB; format = this._replaceInsert(format, 1, (aKBytes / 1000).toFixed(1)); format = this._replaceInsert(format, 2, aTotalKBytes); }
Comment 11•21 years ago
|
||
May I suggest to change the wording too? It currently says "xx of 0 KB at yy KB/sec; ??? remain" What about "xx KB at yy KB/s; unknown total size" or something?
I can't find the testcase link to see if this appears under Linux.
Reporter | ||
Comment 13•21 years ago
|
||
Hum, the testcase link is listed above and it works - http://www.pikslar.com/temp/Bisi/firebird/download.htm Benoit: this would be a nice long-term solution (like IE handling of unknown file size downloads).
OS -> All requested, I triggered the bug on Linux. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040126 Firebird/0.8.0+ (.:MrC:.)
Reporter | ||
Updated•21 years ago
|
OS: Windows 2000 → All
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040201 Firebird/0.8.0+ (daihard: XFT+GTK2; optimized for P4/SSE-2) Triggered it again, this time on a trunk build.
Comment 16•21 years ago
|
||
*** Bug 235614 has been marked as a duplicate of this bug. ***
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040403 Firefox/0.8.0+ (daihard: XFT+GTK2; opt. for P4/SSE-2) Still present, with the original testcase.
Reporter | ||
Comment 18•21 years ago
|
||
I've made a temporary patch, following pike's comment, which works with my own firefox build. I'll try to find&create a long-term solution as soon as possible.
Reporter | ||
Updated•21 years ago
|
Attachment #146986 -
Flags: review?(bugs)
Reporter | ||
Updated•21 years ago
|
Flags: blocking1.0?
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a) Gecko/20040428 Firefox/0.8.0+ (daihard: XFT+GTK2; opt. for P4/SSE-2) Still present, with the original testcase. blocking1.0? indeed.
Reporter | ||
Comment 22•21 years ago
|
||
Attachment #139405 -
Attachment is obsolete: true
Reporter | ||
Comment 23•21 years ago
|
||
Attachment #139406 -
Attachment is obsolete: true
Reporter | ||
Comment 24•21 years ago
|
||
Adding statusFormatUnknown for KB and MB, changing statusFormat (removed "remain" after #3)...
Attachment #146986 -
Attachment is obsolete: true
Reporter | ||
Comment 25•21 years ago
|
||
Changing function DownloadProgressListener (adding statusFormat for unknown filesize in KB/MB), the "update time remaining" part of the script (adding " remain" to the downloads with known filesize; changing ??? to unknown filesize for the downloads with unknown filesize) and the function _formatKBytes (adding else if for progressHasMB && !totalHasMB and changing the if [actually now it's an else if, but that's not important] for !progressHasMB && !totalHasMB).
Reporter | ||
Updated•21 years ago
|
Attachment #147988 -
Flags: review?(bugs)
Reporter | ||
Updated•21 years ago
|
Attachment #147989 -
Flags: review?(bugs)
Comment 26•21 years ago
|
||
*** Bug 243775 has been marked as a duplicate of this bug. ***
Updated•21 years ago
|
Attachment #146986 -
Flags: review?(bugs)
Does anyone have a rough idea of when attachments 147988 and 147989 will be reviewed and checked in?
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P4
Comment 28•20 years ago
|
||
*** Bug 246466 has been marked as a duplicate of this bug. ***
Comment 29•20 years ago
|
||
*** Bug 248929 has been marked as a duplicate of this bug. ***
Comment 30•20 years ago
|
||
*** Bug 250683 has been marked as a duplicate of this bug. ***
Reporter | ||
Updated•20 years ago
|
Attachment #147988 -
Attachment is obsolete: true
Attachment #147988 -
Flags: review?(bugs)
Reporter | ||
Updated•20 years ago
|
Attachment #147989 -
Attachment is obsolete: true
Attachment #147989 -
Flags: review?(bugs)
Reporter | ||
Comment 31•20 years ago
|
||
oops, forgot to set the PR blocking flag. There are also some l10n issues. I'll try to fix those issues till tomorrow and hope I didn't miss 1.0PR...
Flags: blocking-aviary1.0PR?
Comment 32•20 years ago
|
||
any progress on this? think we need the patch this week if it is going to make PR1
Whiteboard: [have patch]
Comment 33•20 years ago
|
||
trying to shut down for PR next week. is a patch ready? thanks
Updated•20 years ago
|
Whiteboard: [have patch] → [have patch] affects l10n
Reporter | ||
Comment 34•20 years ago
|
||
sorry for the delay, I had some problems with my motherboard. I'll upload the patch in a few minutes...
Reporter | ||
Comment 35•20 years ago
|
||
all in one...
Reporter | ||
Updated•20 years ago
|
Attachment #156697 -
Flags: review?(bugs)
Assignee | ||
Comment 36•20 years ago
|
||
Comment on attachment 156697 [details] [diff] [review] patch r+a=ben@mozilla.org, we need to get this in now for l10n freeze.
Attachment #156697 -
Flags: review?(bugs)
Attachment #156697 -
Flags: review+
Attachment #156697 -
Flags: approval-aviary+
Updated•20 years ago
|
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
Reporter | ||
Comment 37•20 years ago
|
||
Could somebody check this in (I don't have a cvs account)? Thanks Ben!
Reporter | ||
Comment 38•20 years ago
|
||
mconnor checked in the patch to the aviary branch...
Keywords: fixed-aviary1.0
Comment 39•20 years ago
|
||
(In reply to comment #38) > mconnor checked in the patch to the aviary branch... If the filesize reaches 2^32 * 1024 bytes it will start counting backwards from minus something.. at -xx kb/sec which looks very odd, i'll attach a picture that has the file from my explorer imposed on top, sorry for the bad edit, i'm sure you'll see what i mean.. Not sure if I should create a new bug for this ?
Comment 40•20 years ago
|
||
Comment 41•20 years ago
|
||
(In reply to comment #40) > Created an attachment (id=165125) > displays firefox's behaviour downloading files >2GiB > >2GB case is bug 228968.
Reporter | ||
Updated•20 years ago
|
Keywords: aviary-landing
Updated•20 years ago
|
Flags: blocking-aviary1.1?
Comment 42•20 years ago
|
||
according to lxr, the code is there, can anyone reproduce on a current trunk build?
Comment 43•20 years ago
|
||
(In reply to comment #42) > according to lxr, the code is there, can anyone reproduce on a current trunk build? WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050115 Firefox/1.0+
Reporter | ||
Comment 44•20 years ago
|
||
Yep, the code was checked in, however there is a bug, that I (and some people at m'zine) discovered recently... If the file is smaller than 1MB (1024KB) and the filesize is known, we get something like "xx KB at yy KB/s; zz remain" (the expected line should say "xx KB of xx KB at yy KB/s; zz remain"). I'll make the patch tomorrow and I think we don't need a new bug fo that.
Keywords: aviary-landing
Updated•20 years ago
|
Whiteboard: [have patch] affects l10n → see comment 44
Version: unspecified → Trunk
Reporter | ||
Comment 45•20 years ago
|
||
The patch fixes the small regression while downloading files smaller than 1MB. Asking for review... It's a simple fix, so it could also get the aviary1.0.1 approval, but let's wait for the review.
Reporter | ||
Updated•20 years ago
|
Attachment #172093 -
Flags: review?(bugs)
Comment 46•20 years ago
|
||
*** Bug 252547 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 47•20 years ago
|
||
Comment on attachment 172093 [details] [diff] [review] KB fix r=ben@mozilla.org
Attachment #172093 -
Flags: review?(bugs) → review+
Assignee | ||
Updated•20 years ago
|
Flags: blocking-aviary1.1? → blocking-aviary1.1+
Assignee | ||
Comment 48•20 years ago
|
||
*** Bug 259995 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Whiteboard: see comment 44 → see comment 44 [checkin-needed]
Comment 49•20 years ago
|
||
I can check this in if noone else want.
Reporter | ||
Comment 50•20 years ago
|
||
(In reply to comment #49) > I can check this in if noone else want. I have already contacted Mike over irc and he said he would check in the "KB fix" patch... Maybe he didn't have time to get to this bug, so feel free to check in the last patch.
Comment 51•20 years ago
|
||
Comment on attachment 172093 [details] [diff] [review] KB fix checked in
Reporter | ||
Comment 52•20 years ago
|
||
Thanks to Ben, Mike and Zbigniew! -> fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: see comment 44 [checkin-needed]
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•