232111 - Wallet should use the newer nsIPrefService APIs instead of nsIPref

Status: RESOLVED WONTFIX

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Mikael Parknert]

nsIPref is deprecated

Comment 1

[Jesse McNelis]

I'm a bit of a noob here.
This seems like a hopefully fairly simple bug.

Comment 2

[Vidar Haarr (not reading bugmail)]

Jesse: I'm not sure this is worth it ...
AFAIK, the wallet module is not used by Firefox or Thunderbird, only Seamonkey.
Eventually the plan is to move Seamonkey to Toolkit, so the entire wallet
extension will be obsolete ...

But no, this is not a simple bug. The Wallet code is horrible and ugly - there
are far better bugs for noobs to take on. 

Take a look at <http://www.mozilla.org/contribute/hacking/first-bugs/>.

Comment 3

[Vidar Haarr (not reading bugmail)]

Attachment: cleans up nsWalletService.cpp

I'm just posting this here for the sake of trying to get a clean tree.

I do not think I'll fixup wallet any more than this (but maybe), so if dveditz
or someone wants to review this, that'd be cool.

Comment 4

[Worcester12345]

(In reply to comment #3)
> Created an attachment (id=195723) [details]
> cleans up nsWalletService.cpp
> 
> I'm just posting this here for the sake of trying to get a clean tree.
> 
> I do not think I'll fixup wallet any more than this (but maybe), so if dveditz
> or someone wants to review this, that'd be cool.
Did you mean to ask for a review on this?

Comment 5

[Serge Gautherie (:sgautherie)]

R.WontFix, after bug 473827.