232123 - In <viewZoomOverlay.js>, "Error: textZoomMenu has no properties", (When opening "Tools > Search Addresses...")

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Serge Gautherie (:sgautherie)]

Found while working on bug 162432 (Dv1 part):
{
Error: textZoomMenu has no properties
Source File: chrome://communicator/content/viewZoomOverlay.js
Line: 229
}

It happens because of
{
--> ABSearchDialog.xul
    -> mailWindowOverlay.xul -> viewZoomOverlay.xul -> viewZoomOverlay.js ->
textZoomMenu
}
This error has no(!!?) consequence beside cluttering the JS.Console :-|

From neil's email:
{
What's happening is that viewZoomOverlay is only designed to be used in windows
with a zoom menu. This means that mailWindowOverlay.xul should only be used in
windows with a zoom menu. I think I fixed this in SearchDialog.xul by removing
mailWindowOverlay.xul but that meant that I had to write out the status bar
(rather than using the overlay) and manually include utilityOverlay.xul as part
of the fix. Hopefully something similar will fix all of these errors at once :-)
}

I'm not going to do it (now), then I file this separate bug:
*Doing it the way neil suggests, might undo some of bug 162432 (Dv1 part) patch:
 which will be fine. (I'm fixing the other errors in the meantime !)
*May be there could be a way to move the status bar related code to a different
but common place ??

Comment 1

[Serge Gautherie (:sgautherie)]

I often forget it these days:
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113] (W98SE)

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <ABSearchDialog.xul> [Checkin: See comment 4]

Would fix
{{
Error: redeclaration of const NS_BAYESIANFILTER_CONTRACTID
Source File: chrome://messenger/content/mailCommands.js
Line: 423
--> ABSearchDialog.xul
    -> mailWindowOverlay.xul -> mailCommands.js !
    -> mailCommands.js // removed

Error: redeclaration of const MSG_FLAG_IMAP_DELETED
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 28
--> ABSearchDialog.xul
    -> mailWindowOverlay.xul -> mailWindowOverlay.js !
    -> mailWindowOverlay.js // removed
}}
When opening "Tools > Search Adresses...";

but removing/replacing 'mailWindowOverlay.xul' might be a better/harder way to
go !?

Comment 3

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.8) Gecko/20050511] (release) (W98SE)

Bug still there in MAS v1.7.x branch.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050701] (nightly) (W98SE)

And line changed a little in MAS Trunk.

{{
Error: textZoomMenu has no properties
Source File: chrome://communicator/content/viewZoomOverlay.js
Line: 233
}}

Comment 4

[Mark Banner (:standard8)]

This has been fixed by the patch I just checked in on bug 263951 (comment 16)

Comment 5

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050825 SeaMonkey/1.0a]
(nightly) (W98SE)

V.Fixed