232161 - no UI to remove an invalid query

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There's no UI to remove a query that gives an error.

Steps to reproduce:
 1. create an account
 2. do a query for all bugs owned by that account, and save the query
 3. change the email address associated with that account
 4. run the query

Actual results:
 4. Error message that the user does not exist, and no way to remove the query
(since the only way to remove a saved query is now by running it)

Expected results:
 4. Error message for a saved query should give the option of removing the query
or editing it.

Comment 1

[Gervase Markham [:gerv]]

Yep, this is my bug. I meant to fix it after I rearchitected saved queries, but
it slipped my mind. Apologies. I'll get to it this evening (GMT).

Gerv

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Should also be able to *edit* an invalid query.  

Q: When a user changes his email address, shouldn't queries with that address
be automatically updated?

Comment 3

[Dave Miller [:justdave]]

(In reply to comment #2)
> Q: When a user changes his email address, shouldn't queries with that address
> be automatically updated?

Yes, but that's bug 192052.

Comment 4

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This adds a "remove saved search" link to all error pages caused by running
saved searches.

Gerv

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 139935 [details] [diff] [review]
Patch v.1

add a way to load the search into the query page, too, and I'll go for it. 
("Edit this search")

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 139935 [details] [diff] [review]
Patch v.1

>+  <p>  
>+    Alternatively, you can    
>+    <a href="buglist.cgi?cmdtype=dorem&amp;remaction=forget&amp;namedcmd=
>+                  [% namedcmd FILTER html %]">forget</a>
>+    this saved search: '[% namedcmd FILTER html %]'.

Nits: indent [% namedcmd %] 13 spaces instead of 18 (so it lines up with the
"b" rather than the "s" in buglist.cgi), and make all of "forget this saved
search" be the link text, as "forget" is a small target (harder to see, harder
to click), unless you implement the "edit" link I just saw justdave requesting,
in which case "forget" is the appropriate link text.

r=myk

Comment 7

[Gervase Markham [:gerv]]

Attachment: Patch v.2

This one adds editing capabilities. One begins to understand how powerful this
object-orientated malarkey is...

Gerv

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 139968 [details] [diff] [review]
Patch v.2

assuming it works, that looks good :)

Comment 9

[Gervase Markham [:gerv]]

approval, then?

Gerv

Comment 10

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.45; previous revision: 1.44
done

Gerv

Comment 11

[Bradley Baetz (:bbaetz)]

Thats just horrible :) If we were using exceptions, the somethingin buglist.cgi
would catch the user-error. However, we dont' do that, so.....

Comment 12

[:aceman]

Which version of bugzilla was this checked into? 2.18? When will this get on b.m.o?

Comment 13

[Gervase Markham [:gerv]]

It was checked into the latest CVS, and will get onto b.m.o. when it next
updates, which will be as soon as we've fixed any other regressions we find. :-)

Gerv

Comment 14

[:glob ✱]

*** Bug 252064 has been marked as a duplicate of this bug. ***