Closed Bug 232175 Opened 21 years ago Closed 20 years ago

Refactor nsNativeThemeWin

Categories

(SeaMonkey :: Themes, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: isaachh, Assigned: isaachh)

References

Details

Attachments

(1 file, 1 obsolete file)

From bug 181490:
Make nsNativeThemeWin inherit from nsNativeTheme to remove some duplicated code.
Attached patch Patch (obsolete) — Splinter Review
Status: NEW → ASSIGNED
Component: GFX: Win32 → Themes
Isaac, is that patch ready to go?  That is, is it at the point where it needs
reviews?
Attachment #139896 - Attachment is obsolete: true
Since the patch in bug 181490 has been checked-in, I'm uploading a new patch.
Comment on attachment 144110 [details] [diff] [review]
Patch (up to the trunk)

Requesting r/sr.

This patch is just a code cleanup -- eliminating a few obvious duplicate member
variables and functions of nsNativeTheme and nsNativeThemeWin.

Changes in nsNativeTheme::IsWidgetStyle() is from bug 181490, but here, mac is
also affected.
Attachment #144110 - Flags: superreview?(bzbarsky)
Attachment #144110 - Flags: review?(bryner)
I won't be able to get to the review till I come back from my trip at this
point... (a week and a half from now at least).
Comment on attachment 144110 [details] [diff] [review]
Patch (up to the trunk)

Looks good.
Attachment #144110 - Flags: review?(bryner) → review+
Comment on attachment 144110 [details] [diff] [review]
Patch (up to the trunk)

sr=bzbarsky.

Please ping me when 1.8 opens (or once this has approval if you go for 1.7) and
I'll check it in, ok?
Attachment #144110 - Flags: superreview?(bzbarsky) → superreview+
Blocks: 197001
Patch checked in to 1.8a trunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: