232579 - gtk2 native theme lacks edit control outline

Status: RESOLVED INCOMPLETE

(Core Graveyard :: GFX: Gtk, defect)

Description

[Darin Fisher]

gtk2 native theme lacks edit control outline.

under redhat9 or fedora core 1:

1) select Mist as your desktop theme
2) load firebird w/ classic theme

notice that the outline is missing around the URL bar.  in fact, any edit
control lacks an outline.  because the colors of this GTK theme are so light, it
makes it very difficult to see an edit box in many cases.

Comment 1

[Brian Ryner (not reading)]

I looked at this briefly and the problem appears to be that the Thinice engine
(and the Mist engine, based on it) have a check that makes it bail on
draw_shadow if the size of the drawable is not the same as the width and height
passed in.  This is bad for us since our drawable will be larger.

The code in the theme engine seems dubious to me; I'm not sure what it's trying
to accomplish.  At any rate, the only ways I see we could work around this on
our end are:

- use a temporary pixmap which is the expected size of the entry's drawable. 
we'd need to copy the relevant bits to the temporary pixmap, call gtk to draw to
it, then copy the bits back.

- use native text fields

Comment 2

[Mats Palmgren (inactive)]

Does this bug still occur in a recent trunk build?
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

Comment 3

[Samuel Sidler (old account; do not CC)]

I'm going to go ahead and close this. Darin or Brian, if you can still reproduce this, feel free to reopen, but both Linux and Firefox have changed substantially in the last three years, so it's likely no longer an issue.