233402 - search for file: urls if what i type starts with / or c:\

Status: RESOLVED INACTIVE

(Firefox :: Address Bar, defect)

Description

[Patrick McCormick]

This is the Firebird version of bug 97031.  (Mozilla and Firebird have separate 
autocomplete systems.)

Steps to Reproduce:
1. Type in the url bar a local page:
==> file:///c:/boot.ini
2. Press "Enter"
3. Type "c:/boot"
==> nothing in dropdown
4. Type "file:///c:/boot"
==> file:///c:/boot.ini appears in dropdown

Expected Behavior:
In step 3, "file:///c:/boot.ini" should appear in the dropdown.

The ability to autocomplete on "http://", "https://", etc. was added in bug 
94870.  For whatever reason, file: didn't make the cut.

Comment 1

[Patrick McCormick]

Attachment: patch to toolkit/components/history/src/nsGlobalHistory.cpp

This patch has a platform-specific region:

#if defined(XP_WIN) || defined(XP_OS2)
// on windows we want "e:/foo" to match "file:///e:/foo"
#define FILE_SCHEME_PREFIX "file:///"
#else
// on unix we want "/e/foo" to match "file:///e/foo"
#define FILE_SCHEME_PREFIX "file://"
#endif

I dislike writing platform-specific code, but in this case it's the only way to
achieve "least surprise" UI.

Comment 2

[benc]

This is one of those spots where you do want some platform specific code,
because in Windows, people will be cutting and pasting dos style paths from
other programs.

Comment 3

[Patrick McCormick]

Attachment: updated patch to add prefix to nsGlobalHistory.cpp

fixes some slip due to replacement of NS_QuickSort, also forgot to bump the
AUTOCOMPLETE_PREFIX_LIST_COUNT up to 7.

Comment 5

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.