Closed Bug 233480 Opened 20 years ago Closed 20 years ago

weird things happen when root is 'display: inline'

Categories

(Core :: Layout: Block and Inline, defect, P2)

Product:
Core
Component:
Layout: Block and Inline
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.7alpha

People

(Reporter: dbaron, Assigned: dbaron)

References

(
URL
)

Details

(Whiteboard: [patch])

Attachments

(1 file, 2 obsolete files)

patch
12.73 KB, patch
Details | Diff | Splinter Review 
The fact that my patch to bug 229654 regressed the centering in the testcase in
bug 229654 (attachment 140880 [details]) suggests that something is broken when the root
is inline.  Probably the best fix is to fix up the computed style data according
to the fixups for the root element in CSS2.1 9.2.4 rather than doing the fixup
in ConstructRootFrame.
Blocks: 111397
Attached patch patch (obsolete) — — Splinter Review 

    
  

        Attachment #140919 -
        Flags: superreview?(bzbarsky)

        Attachment #140919 -
        Flags: review?(bzbarsky)

    
  
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.7alpha

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (obsolete)
        — 
          — Splinter Review
      

    


  
A little more cleanup of GetUniqueStyleData

        Attachment #140919 -
        Attachment is obsolete: true

    
  

        Attachment #140919 -
        Flags: superreview?(bzbarsky)

        Attachment #140919 -
        Flags: review?(bzbarsky)

    
  

        Attachment #140920 -
        Flags: superreview?(bzbarsky)

        Attachment #140920 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 140920 [details] [diff] [review]
patch

Could you remove the aPresContext arg of GetUniqueStyleData while you're here? 
r+sr=bzbarsky with that.

        Attachment #140920 -
        Flags: superreview?(bzbarsky)

        Attachment #140920 -
        Flags: superreview+

        Attachment #140920 -
        Flags: review?(bzbarsky)

        Attachment #140920 -
        Flags: review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #140920 -
        Attachment is obsolete: true
Blocks: 215063

    
    

    
  
Fix checked in to trunk, 2004-02-08 22:55/56 -0800.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Blocks: 144004

          You need to log in
          before you can comment on or make changes to this bug.