weird things happen when root is 'display: inline'

RESOLVED FIXED in mozilla1.7alpha

Status

()

Core
Layout: Block and Inline
P2
normal
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.7alpha
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch], URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

13 years ago
The fact that my patch to bug 229654 regressed the centering in the testcase in
bug 229654 (attachment 140880 [details]) suggests that something is broken when the root
is inline.  Probably the best fix is to fix up the computed style data according
to the fixups for the root element in CSS2.1 9.2.4 rather than doing the fixup
in ConstructRootFrame.
Blocks: 111397
(Assignee)

Comment 1

13 years ago
Created attachment 140919 [details] [diff] [review]
patch
(Assignee)

Updated

13 years ago
Attachment #140919 - Flags: superreview?(bzbarsky)
Attachment #140919 - Flags: review?(bzbarsky)
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.7alpha
(Assignee)

Comment 2

13 years ago
Created attachment 140920 [details] [diff] [review]
patch

A little more cleanup of GetUniqueStyleData
Attachment #140919 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #140919 - Flags: superreview?(bzbarsky)
Attachment #140919 - Flags: review?(bzbarsky)
(Assignee)

Updated

13 years ago
Attachment #140920 - Flags: superreview?(bzbarsky)
Attachment #140920 - Flags: review?(bzbarsky)
Comment on attachment 140920 [details] [diff] [review]
patch

Could you remove the aPresContext arg of GetUniqueStyleData while you're here? 
r+sr=bzbarsky with that.
Attachment #140920 - Flags: superreview?(bzbarsky)
Attachment #140920 - Flags: superreview+
Attachment #140920 - Flags: review?(bzbarsky)
Attachment #140920 - Flags: review+
(Assignee)

Comment 4

13 years ago
Created attachment 140921 [details] [diff] [review]
patch
Attachment #140920 - Attachment is obsolete: true
Blocks: 215063
(Assignee)

Comment 5

13 years ago
Fix checked in to trunk, 2004-02-08 22:55/56 -0800.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Blocks: 144004
You need to log in before you can comment on or make changes to this bug.