Last Comment Bug 233480 - weird things happen when root is 'display: inline'
: weird things happen when root is 'display: inline'
Status: RESOLVED FIXED
[patch]
:
Product: Core
Classification: Components
Component: Layout: Block and Inline (show other bugs)
: Trunk
: x86 Linux
: P2 normal (vote)
: mozilla1.7alpha
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
http://bugzilla.mozilla.org/attachmen...
Depends on:
Blocks: 111397 144004 215063
  Show dependency treegraph
 
Reported: 2004-02-08 21:27 PST by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2007-02-04 23:25 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (6.43 KB, patch)
2004-02-08 22:00 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
no flags Details | Diff | Review
patch (6.96 KB, patch)
2004-02-08 22:14 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
bzbarsky: superreview+
Details | Diff | Review
patch (12.73 KB, patch)
2004-02-08 22:53 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
no flags Details | Diff | Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-02-08 21:27:22 PST
The fact that my patch to bug 229654 regressed the centering in the testcase in
bug 229654 (attachment 140880 [details]) suggests that something is broken when the root
is inline.  Probably the best fix is to fix up the computed style data according
to the fixups for the root element in CSS2.1 9.2.4 rather than doing the fixup
in ConstructRootFrame.
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-02-08 22:00:20 PST
Created attachment 140919 [details] [diff] [review]
patch
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-02-08 22:14:23 PST
Created attachment 140920 [details] [diff] [review]
patch

A little more cleanup of GetUniqueStyleData
Comment 3 Boris Zbarsky [:bz] 2004-02-08 22:51:15 PST
Comment on attachment 140920 [details] [diff] [review]
patch

Could you remove the aPresContext arg of GetUniqueStyleData while you're here? 
r+sr=bzbarsky with that.
Comment 4 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-02-08 22:53:04 PST
Created attachment 140921 [details] [diff] [review]
patch
Comment 5 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-02-08 22:57:19 PST
Fix checked in to trunk, 2004-02-08 22:55/56 -0800.

Note You need to log in before you can comment on or make changes to this bug.