23388 - {css1} margin-top does not work when parent has a border

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[Christine Hoffman]

Using 1/5 build on Win, Mac and Linux.

Steps to reproduce:
1. Open attached testcase
2. There are three divs: the first is nested in a div which has a border; the
second is nested in a div which does not have a border; the third div is in
the BODY

Expected results: All three divs should have a 1 inch top margin
Actual results: The div nested in a bordered div has no top margin

Comment 1

[Christine Hoffman]

Attachment: testcase to demonstrate problem

Comment 2

[Pierre Saslawsky]

The style context is correct.
It works in M12.
It must be Block Layout... Reassigned to Troy.

Comment 3

[troy]

Block bug so re-assigning to Kipp's bug list

Comment 4

[buster]

mass-moving bugs to M15

Comment 5

[Hixie (not reading bugmail)]

Troy, could you see if this is easy to fix? This is quite a serious regression.
Margins were working fine before. Other bugs (most notably bug 16253) are
currently blocked by this.

David: cc'ing you so you know this bug exists...

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See also bug 18187.  Correcting component.

Comment 7

[troy]

Okay, it's fixed. Let me know if there are any other high priority Kipp bugs to
look at

Comment 8

[Hixie (not reading bugmail)]

Verified attachement works as expected in 2000011308 Win32 OPT build.

Thanks Troy. I'll tell you if I see any others.

Comment 9

[Hixie (not reading bugmail)]

Migrating from {css1} to css1 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...

Comment 10

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/044d7ceb298c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23388 - Update scrim to match design system