Closed Bug 234293 Opened 17 years ago Closed 17 years ago
unify use of search/query terminology
User-Agent: Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8 In some places (e.g., the toolbar at the bottom of pages) the search feature is called "search." But in other places (e.g., the homepage of Bugzilla, the links at the top of bug reports), it is called "query." One term should be picked and the interface unified to use this one term. Query seems to be in more popular usage, so I suggest it be used. Reproducible: Always Steps to Reproduce: 1. 2. 3.
We've been migrating from "Query" to "Search", as it's more understandable. Some of the instances of "Query" you see on b.m.o. are site-specific templates - but not all of them are. Ones in this second category need fixing. Gerv
This replaces all user-visible instances of the word "query" with "search. Gerv
Assignee: myk → gerv
Status: UNCONFIRMED → ASSIGNED
Comment on attachment 141460 [details] [diff] [review] Patch v.1 Another easy one... Gerv
Attachment #141460 - Flags: review?(justdave)
kiko, dave: ping? This has probably rotted a bit by now, but I do think we want it for 2.18. Gerv
*** Bug 237507 has been marked as a duplicate of this bug. ***
17 years ago
Attachment #141460 - Flags: review?(justdave) → review+
believe it or not, this still applies to tip without errors :)
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.18
OK, revoking approval on this temporarily... the patch on bug 237507 does this in a different way (the name of the term used is defined in the variables template). We need to decide whether that approach is worth it first. Both patches essentially accomplish the same thing, but the other one lets some admin change it back easily if they want.
Flags: approval+ → approval-
I'm very wary about going down the path of making more than a bare minimum of things configurable in this way. The "bug" issue is a perennial one, and we had to allow that - but it requires tests to enforce, and periodic cleanups of bad grammar (see bug 237772) and so on. I've never come across anyone who's said "Bugzilla refers to them as queries, and we always use the term lookups. Is there a way we can change this everywhere?" Without customer requirement, IMO parameterisation is more hassle than it's worth. Gerv
Comment on attachment 141460 [details] [diff] [review] Patch v.1 I also question the value of templatizing such a common term; I wasn't actually very happy with the "bug" templatization, but I can see a reasonable rationale for that, whereas I fail to see a strong one here. Let's fix this and get on with life.
17 years ago
Flags: approval- → approval+
Fixed. Checking in template/en/default/account/prefs/footer.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/footer.html.tmpl,v <-- footer.html.tmpl new revision: 1.5; previous revision: 1.4 done Checking in template/en/default/index.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/index.html.tmpl,v <-- index.html.tmpl new revision: 1.16; previous revision: 1.15 done Checking in template/en/default/sidebar.xul.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/sidebar.xul.tmpl,v <-- sidebar.xul.tmpl new revision: 1.12; previous revision: 1.11 done Checking in template/en/default/bug/navigate.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/navigate.html.tmpl,v <-- navigate.html.tmpl new revision: 1.6; previous revision: 1.5 done Checking in template/en/default/bug/process/verify-new-product.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/verify-new-product.html.tmpl,v <-- verify-new-product.html.tmpl new revision: 1.14; previous revision: 1.13 done Checking in template/en/default/global/messages.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v <-- messages.html.tmpl new revision: 1.22; previous revision: 1.21 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.53; previous revision: 1.52 done Checking in template/en/default/list/server-push.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/server-push.html.tmpl,v <-- server-push.html.tmpl new revision: 1.5; previous revision: 1.4 done Checking in template/en/default/search/boolean-charts.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v <-- boolean-charts.html.tmpl new revision: 1.8; previous revision: 1.7 done Checking in template/en/default/search/knob.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v <-- knob.html.tmpl new revision: 1.15; previous revision: 1.14 done Gerv
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Was this fix checked into 2.17.6? b.m.o homepage still displays a link to "Query Page". Prog.
Either: - b.m.o. is not running the latest code Or: - b.m.o. has a custom front page and it hasn't been updated Or: - both. Gerv
Actually, it's not just the front page. If you scroll down this very page you'll see that "Query page" and "Search" both point to http://bugzilla.mozilla.org/query.cgi Prog.
Indeed. That will continue to be the case. We didn't rename the .cgi. Gerv
There's really no need to change the name of the cgi. Replacing "Query page" with "Advanced Search" should do. In fact, almost any terminology that uses the term "Search" will be more consistent. Prog.
All "Query page" links are gone now. Verifying. Prog.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.