23470 - The "Open" button in the Attach dialog should be "Attach"

Status: NEW

(MailNews Core :: Composition, defect)

Description

[Henrik Gemal]

The button should be "Attach" instead of "Open" since you dont open the file (
attachment). You attach the file!

Comment 1

[Phil Peterson]

4.x behaves the same way. Reassign to ducarroz for M18. Also cc'ing trudelle
since someone in his group would probably need to make the platform-specific
dialogs do this (if they don't already).

Comment 2

[Peter Trudelle]

cc sdagley, who owns the standard file dialogs

Comment 3

[lchiang]

This is a good candidate for future milestone.

Comment 4

[varada]

Adding mail3 keyword.

Comment 5

[scottputterman]

changing component.

Comment 6

[scottputterman]

marking nsbeta1-

Comment 7

[Håkan Waara]

I don't think it's possible to change the button caption in that dialog, not
sure though. The code that is called lives in here:
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/content/MsgComposeCommands.js#1455

Comment 8

[timeless]

the w32 common dialogs certainly support changing the strings, it's possible 
that our file picker doesn't expose that.

Comment 9

[Henrik Gemal]

Outlook Express says "Attach"

Should I file a bug against the filepicker? What component is that?

Comment 10

[Ken Harris]

In mailnews, File > Attachments > (some attachment) > Save
gives a dialog with a "Save" button, but File > Attachments
> Save All... gives a dialog with a "Select" button.  So
somebody knows how to change the save-dialog-button-text.
(Who wrote the Save All Attachments window?)

Comment 11

[Jean-Francois Ducarroz]

Over to varada

Comment 12

[scottputterman]

moving to 1.0

Comment 13

[Adrian Ulrich]

*** Bug 144080 has been marked as a duplicate of this bug. ***

Comment 14

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 15

[Christian Krause]

Attachment: patch changes the name of the button

I've created a patch against mozilla 1.7.8 which solves the problem by changing
the apply button of the attach filedialog to "Attach".

At the moment it only works with the gtk2 toolkit, so a build with another
toolkit might not work. If the mozilla developers think the patch is otherwise
reasonable, it would be easy to get the patch working with the other toolkits
(either it is possible to change the apply button to "Attach" in the other
toolkits or fall back to the old behaviour could be implemented).

Please have a look at my patch. Can anybody please request a review? I don't
know who should be the Requestee.

It would be nice if this small problem could be solved, because it is really an
annoying usability issue.

Thanks!

Best regards,
Christian

Comment 16

[Mike Cowperthwaite]

(In reply to comment #15)
> At the moment it only works with the gtk2 toolkit, so a build with another
> toolkit might not work. 

WILL not work.  Nobody's going to approve a patch that's demonstrably not 
working for all platforms.

Also, you've hardcoded the word "Attach" into the source, that's not going to 
fly either.

Comment 17

[Christian Krause]

(In reply to comment #16)
> (In reply to comment #15)
> > At the moment it only works with the gtk2 toolkit, so a build with another
> > toolkit might not work. 
> 
> WILL not work.  Nobody's going to approve a patch that's demonstrably not 
> working for all platforms.

Yes, I know. But I want to be sure that I fixed it in the right way (by adding a
new mode to nsIFilePicker.idl) before I touch the other platforms.

Does a patch have a chance that would fix the problem for gtk2 and use the old
behaviour for the other toolkits as fall back? I don't think I can test all the
other toolkits as well. But this would be an improvement anyway, because the
maintainers of the other toolkits could then easily use the new mode.

> Also, you've hardcoded the word "Attach" into the source, that's not going to 
> fly either.

What's the preferred way to introduce such user visible strings (which should be
translated as well)?

Comment 18

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 19

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 20

[Wayne Mery (:wsmwk)]

comment 17 has unanswered question

Comment 21

[Magnus Melin [:mkmelin]]

I doubt such a patch would have much of making it in, no.
Translated strings should be in .properties/.dtd files - though in this case (it's native file pickers) i'm not even sure localization is done inside mozilla code - didn't look though.