234844 - NS_HTMLEDITOR_COMMANDTABLE_CID and NS_HTMLEDITOR_DOCSTATE_COMMANDTABLE_CID have malformed CIDs

Status: RESOLVED DUPLICATE of bug 224678

(SeaMonkey :: Composer, defect)

Description

[timeless]

nsComposerRegistration.cpp
r:/mozilla\editor\composer\src\nsComposerRegistration.cpp(59) : warning C4305:
'initializing' : truncation from 'int' to 'PRUint8'
r:/mozilla\editor\composer\src\nsComposerRegistration.cpp(59) : warning C4309:
'initializing' : truncation of constant value
r:/mozilla\editor\composer\src\nsComposerRegistration.cpp(60) : warning C4305:
'initializing' : truncation from 'int' to 'PRUint8'
r:/mozilla\editor\composer\src\nsComposerRegistration.cpp(60) : warning C4309:
'initializing' : truncation of constant value
r:/mozilla\editor\composer\src\nsComposerRegistration.cpp(229) : warning C4305:
'initializing' : truncation from 'int' to 'PRUint8'
r:/mozilla\editor\composer\src\nsComposerRegistration.cpp(229) : warning C4309:
'initializing' : truncation of constant value
r:/mozilla\editor\composer\src\nsComposerRegistration.cpp(233) : warning C4305:
'initializing' : truncation from 'int' to 'PRUint8'
r:/mozilla\editor\composer\src\nsComposerRegistration.cpp(233) : warning C4309:
'initializing' : truncation of constant value

{ 0x7a727843, 0x6ae1, 0x11d7, { 0xa5eb, 0x00, 0x03, 0x93, 0x63, 0x65, 0x92 } }
                                  ^^^^                                     ^^
{ 0x800e07bc, 0x6ae1, 0x11d7, { 0x959b, 0x00, 0x03, 0x93, 0x63, 0x65, 0x92 } }
                                  ^^^^                                     ^^

I suppose the 'correct' fix is to just reissue cid's for them.

Comment 1

[Ben Fowler]

I don't think that I compile the file that you have fingered, but I do have
this patch for the composer source which you may want to consider.

RCS file: /cvsroot/mozilla/editor/composer/src/nsEditingSession.cpp,v          
                                                       
retrieving revision 1.24
diff -u -r1.24 nsEditingSession.cpp
--- src/nsEditingSession.cpp    11 Feb 2004 15:40:34 -0000      1.24
+++ src/nsEditingSession.cpp    19 Feb 2004 06:03:05 -0000
@@ -672,7 +672,7 @@
     }
   }
   //
-  // A network or document Request as finished...
+  // A network or document Request has finished...
   //
   else if (aStateFlags & nsIWebProgressListener::STATE_STOP)
   {
@@ -703,6 +703,7 @@
       nsCOMPtr<nsIChannel> channel = do_QueryInterface(aRequest);
       nsresult rv = EndDocumentLoad(aWebProgress, channel, aStatus,
                                     IsProgressForTargetDocument(aWebProgress));
+      NS_WARN_IF_FALSE( !rv, "nsEditingSession::OnStateChange EndDocumentLoad
returned with error" );

 #ifdef NOISY_DOC_LOADING
       printf("STATE_STOP & STATE_IS_DOCUMENT flags=%x\n", aStateFlags);
 #endif
@@ -930,6 +931,7 @@
   if (domWindow)
   {
     nsresult rv = TearDownEditorOnWindow(domWindow);
+    NS_WARN_IF_FALSE( !rv, "nsEditingSession::StartDocumentLoad
TearDownEditorOnWindow returned with error" );

   }

   if (aIsToBeMadeEditable)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Ben, that patch is unrelated to this bug and very very wrong.  Nonzero rv does
NOT indicate failure.  Please feel free to mail me if you have any questions.

Comment 3

[Ben Fowler]

Sorry for submitting duff info, but I suspect that there an 'unused variable'
warning there. Would you like me to try again?

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) nsEditingSession.cpp: (unrelated) s/as/has/ [Checkin: Comment 6]

(In reply to comment #1)

> -  // A network or document Request as finished...
> +  // A network or document Request has finished...

Let it be done.

> @@ -703,6 +703,7 @@
>        nsresult rv = EndDocumentLoad(aWebProgress, channel, aStatus,
> @@ -930,6 +931,7 @@
>      nsresult rv = TearDownEditorOnWindow(domWindow);

These unused |nsresult rv| were removed by bug 209020.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 379335 [details] [diff] [review]
(Av1) nsEditingSession.cpp: (unrelated) s/as/has/
[Checkin: Comment 6]


http://hg.mozilla.org/mozilla-central/rev/ba70e64391d9