235852 - Ability to delete search plugins using UI

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P1)

Description

[Gids Goldberg]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

The user shouldn't have to manually delete files to remove search plugins, just
as they shouldn't for extensions. There should be a context menu added to the
search plugins dropdown which offers a Delete option. 
I created this bug because Bug 214528 was marked fixed.


Reproducible: Always
Steps to Reproduce:

Comment 1

[Pham]

this is bug 232272

Comment 2

[Michael Hendy (Hendikins)]

Yup, I'll bite, good call...

*** This bug has been marked as a duplicate of 232272 ***

Comment 3

[Hixie (not reading bugmail)]

IMHO no, this bug could be fixed independent of that one. In fact IMHO that
other one might even be WONTFIX (it's suggesting way too much UI) whereas this
bug would just be very simple to fix (e.g. if it worked like we do for
autocomplete).

Reopening and marking as dependent to keep them related.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This was definitely planned for 2.0, as part of the search interface changes.

Comment 5

[Kadir Topal [:atopal]]

Yes, but it is desperately needed now, in 1.5, even 1.0 shouldn't have been
shpipped with such a serious design flaw.
It's really hard to believe: Sure, you can add a search engine, but then you'll
have to live with it forever. That is unless you know that you can delete them
on file level and know where they are stored.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Adds right click delete functionality

I essentially hacked the SearchPluginsHack extension into the source... I
think. This is my first attempt at a patch. I'm not sure if I did it right. I'm
not sure if I've followed exact coding standards or anything really either.
Just an amature MOZ hacker by night and student by day. Please don't kill me if
it sucks.

I know that bigger search enhancements are planned for 2.0, but I was hoping
this could get in for 1.5. Thought maybe I could at least get the ball rolling.
I know I've seen many people disappointed its not in the beta, as they consider
it a bug-fix and not an enhancement. Looking at the proposals in the
search-enhancement bug, I don't think this gets in the way. In fact, it adds a
right click popup for search engines, which seems to be part of the plan, and
doesn't interfere with adding DND or separators later.

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Add right click delete functionality

oncommand="this.parentNode.parentNode.onEnginePopupCommand(event);"
Adds right click delete

Dang it. Forgot to add a context to the menuitems in the last one. Already I've
begun to err.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Fixed in bug 232272.