236194 - "Save Link to Disk" context menu item does not send HTTP referrer

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Jon Henry]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040302 Firefox/0.8.0+

This is a Firefox spinoff of the SeaMonkey bug 196871.

When right-clicking a link to a file (such as one of the files on the page I
supplied in the URL field) and choosing Save Link to Disk, Firefox does not send
the current page as the referrer, as it does when clicking the link normally.
This is a problem on sites such as the one linked to, since they perform a check
on the referrer to make sure it is coming from within their own site. In this
case, Firefox downloads an HTML error message rather than the real file.

The API change in bug 170722 lets us send a referrer when saving a file, and we
should leverage that in Firefox. I have a patch.

Reproducible: Always
Steps to Reproduce:
1. Find a site that authenticates downloads based on the HTTP referrer.
2. Right click a link, Save Link to Disk.


Actual Results:  
Receive an HTML page containing an error, or some other undesirable result.

Expected Results:  
Download the correct file.

Comment 1

[Jon Henry]

Attachment: Proposed patch

In my testing, this patch worked correctly.

Comment 2

[Jesse Ruderman]

*** Bug 233652 has been marked as a duplicate of this bug. ***

Comment 3

[Jesse Ruderman]

*** Bug 223902 has been marked as a duplicate of this bug. ***

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 142739 [details] [diff] [review]
Proposed patch

r=mkaply.

Nice fix. I'll get this in.

Comment 5

[Mike Kaply [:mkaply]]

Fix checked in

Comment 6

[Robin Monks]

*** Bug 235142 has been marked as a duplicate of this bug. ***