Closed Bug 236343 Opened 20 years ago Closed 20 years ago

Full screen mode shows Windows-like minimize/maximize/close buttons on Mac

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.0

People

(Reporter: chris+bugzilla, Assigned: asaf)

References

Details

(Keywords: fixed-aviary1.0, polish)

Attachments

(1 file, 2 obsolete files)

up-to-date
2.97 KB, patch
asaf
: review+
asaf
: approval-aviary+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.6) Gecko/20040206 Firefox/0.8

When you enter full screen mode in Mac FireFox v0.8, minimize, maximize and
close buttons are added to the upper right of the browser window.  This is a
nice feature, but is very incongruous on a Mac since the icons used for those
buttons are the Windows icons.


Reproducible: Always
Steps to Reproduce:
1. Press F11 to enter fullscreen mode

Actual Results:  
See three Windows icons in the upper right of the browser window

Expected Results:  
Not sure.
Should Kevin (webmail@kmgerich.com) be CCed for this bug... after all he is the
Mac theme guy?
We don't need to display the buttons, since we are not hiding the default set
(top left corner).
Assignee: firefox → bugs.mano
Status: NEW → ASSIGNED

    
  

        Attachment #157867 -
        Flags: review?(bugs)

    
  
Flags: blocking-aviary1.0?
Keywords: polish
QA Contact: bugs
Whiteboard: [have patch]

    
  

        Attachment #157867 -
        Flags: review?(bugs) → review?(mconnor)

        Attachment #157867 -
        Flags: review?(mconnor) → review+

    
    

    
  
Comment on attachment 157867 [details] [diff] [review]
#ifndef XP_MACOSX the fullscreencontrol buttons, we have the OS set instead 

Thank you, Mike.

Requesting approval.

        Attachment #157867 -
        Flags: approval-aviary?

    
    

    
  
Comment on attachment 157867 [details] [diff] [review]
#ifndef XP_MACOSX the fullscreencontrol buttons, we have the OS set instead 

a=asa for aviary checkin.

        Attachment #157867 -
        Flags: approval-aviary? → approval-aviary+

    
    

    
  
did this get checked in?
Flags: blocking-aviary1.0mac+
Flags: blocking-aviary1.0?
Flags: blocking-aviary1.0-

    
  
Whiteboard: [have patch] → ready to land

    
    

    
  
This patch will need to be updated due to the changes from Bug 247603. Also,
shouldn't you remove the fullscreencontrol buttons from the Mac defaultset?

    
    

    
  
Comment on attachment 157867 [details] [diff] [review]
#ifndef XP_MACOSX the fullscreencontrol buttons, we have the OS set instead 

need re-approval now that we're past 1.0 RC. setting back to request.

        Attachment #157867 -
        Flags: approval-aviary+ → approval-aviary?

    
    

    
  
Comment on attachment 157867 [details] [diff] [review]
#ifndef XP_MACOSX the fullscreencontrol buttons, we have the OS set instead 

a=asa for aviary checkin but time is short so this would need to land quickly
if it's going to make it.

        Attachment #157867 -
        Flags: approval-aviary? → approval-aviary+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        up-to-date (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #157867 -
        Attachment is obsolete: true

    
  

        Attachment #164690 -
        Flags: review+

        Attachment #164690 -
        Flags: approval-aviary+

    
    

    
  
Steffen, can you check it in please?
Target Milestone: --- → Firefox1.0

    
    

    
  
Comment on attachment 164690 [details] [diff] [review]
up-to-date

argh, wrong file

        Attachment #164690 -
        Attachment is obsolete: true

        Attachment #164690 -
        Flags: review+

        Attachment #164690 -
        Flags: approval-aviary+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        up-to-date
        — 
          — Splinter Review
      

    


  
again.

    
    

    
  
Comment on attachment 164691 [details] [diff] [review]
up-to-date

moving r/a

        Attachment #164691 -
        Flags: review+

        Attachment #164691 -
        Flags: approval-aviary+

    
    

    
  
Checked into branch.
Keywords: fixed-aviary1.0
Whiteboard: ready to land

    
    

    
  
confirmed fixed on Mac Firefox Branch 2004-11-05-06-0.11

    
    

    
  
moving blocking1.0mac bugs to Firefox1.1 Target Milestone.
Target Milestone: Firefox1.0 → Firefox1.1

    
  
Flags: blocking-aviary1.0mac+
Target Milestone: Firefox1.1 → Firefox1.0

    
  
Blocks: macmeta

    
    

    
  
fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: