237209 - Migrate negative/positive review flags on obsolete attachments

Status: NEW

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

This is subtly different from 179256. 

I've been using the patch system more in the past couple of days and here's what
I think should happen when I attach a patch:

If I attach a new patch that obsoletes an old one:

(1) pending (?) review requests are cleared on the obsolete patch and added to
the new patch. Clearing the old ? request tidies up the view a bit. 
(2) review- annotations are added as review? requests on the new patch
(3) review+ annotations are added as review? requests on the new patch (this is
perhaps the default behavior, with the "bring forward review" Aaron talks about
in 179256 as a checkbox option in the create page)

(1) alone would be a huge benefit.

Comment 1

[Dave Miller [:justdave]]

Item #1 is bug 180652.

I don't believe we have any bugs filed for 2 and 3 yet though.

Comment 2

[Mike Cowperthwaite]

Actually, item #1 is bug 180833.  180652 is only about cancelling the pending 
request on obsoleting.

Comment 3

[Christian Reis]

Morphing to cover items 2) and 3) in the list.

Comment 4

[Frédéric Buclin]

I'm not convinced with points 2) and 3). Not taking it for the moment, myk. ;)

Comment 5

[Christian Reis]

2) and 3) would be huge benefits for the most common case (reattaching a patch
after reviewed). This should only happen for patches, not for other types of
attachments.