237534 - selection highlights not visible in "inverse" high-contrast themes

Status: RESOLVED DUPLICATE of bug 1531338

(Core :: Widget: Gtk, defect)

Description

[Bill Haneman]

If you enable tracking of gtk+ themes in mozilla, by using the "Classic" mozilla
theme, and select gnome's HighContrastInverse theme, selection highlights are
not visible.  The end user cannot tell what text is being or has been selected,
though the selection activity does work (text can be cut, copied and pasted).

(filed against accessibility APIs - is there a better component code for theming
issues?)

Comment 1

[R.K.Aa.]

dup of bug 56314?

Comment 2

[Bill Haneman]

IMO not quite the same, but close.  reversing would fail to follow theme colors
in the general case - the gtk+ theme actually specfies which colors should be
used for fg and bg when selecting text.

Comment 3

[R.K.Aa.]

"there are plenty more where that one came from"... how about bug 201220

Comment 4

[Boris Zbarsky [:bzbarsky]]

GTK nsITheme issue.

Comment 5

[R.K.Aa.]

There are so many former instances and variants of this bug.. hard to know where
to begin. Suggesting dup of Linux bug 50814 - See bug 50814 comment 24

Comment 6

[Bill Haneman]

please do not dup this bug.  It captures a specific accessibility issue which
was ignored in bug 50814.  The theming of text selection color is critical to
accessibility.

Comment 7

[Ginn Chen]

I think Edit->Preferences->Appearance->Colors, 'Use System Color' or 'Use my
chosen colors, ignoring the colors and background image specified' will help on
this issue.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Did fixing bug 237535 change things here any?

Comment 9

[Mike Schroepfer]

We'd love to fix this - but doesn't meet the beta2 criteria (since it is an existing issue) so we will not block the release for it.

Comment 10

[Myk Melez [:myk] [@mykmelez]]

This works for me in the latest nightly Firefox 2 build, although perhaps that doesn't use the "Classic" theme.  I'm using the "default" theme in Firefox, and I switched to the "High Contrast Inverse" theme using GNOME's Theme Preferences applet.

With the "Use system colors" preference checked and the "Allow pages to use their own colors" preference unchecked, text is white on a dark blue background.  When I select text, the selection appears as dark blue/black on a light pink background.

If I check "Allow pages to use their own colors", a typical page appears with black text on a white background.  When I select text, the selection appears as light pink text on a dark blue background.

In both cases, selections are visible and usable.

WORKSFORME, or is this really Classic-specific?

Comment 11

[Mark Pilgrim (inactive)]

*** Bug 338464 has been marked as a duplicate of this bug. ***

Comment 12

[Mark Pilgrim (inactive)]

*** Bug 357071 has been marked as a duplicate of this bug. ***

Comment 13

[Mats Palmgren (inactive)]

Does this bug occur in a recent trunk build?
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

Comment 14

[Ginn Chen]

I can reproduce Bug 338464 – Typeaheadfind "highlight all" and Bug 357071 – for selected item in mouse over combobox.

These bugs have been marked as duplicate of this bug.

I can't reproduce for selecting text in html page.

Comment 15

[Ginn Chen]

also text in html button is not readable when mouse over it, with using high contrast inverse theme.
XUL button is good.

Comment 16

[Tim Keenan]

What's the current status on this?  If ther are still lingering issues, we should try to resolve them for FF3. I'm a bit confused re what these issues are, though.

Comment 17

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Should be fixed by Bug 1531338.