237804 - cosmetic problems with about dialog (new artwork)

Status: RESOLVED DUPLICATE of bug 315297

(Firefox :: General, defect)

Description

[Jan aka Elve]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040317 Firefox/0.8.0+ (by Elve: optimized for G7)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040317 Firefox/0.8.0+

1. Since the new artwork is checked in (together with an increaesd window size
of the about dialog) the scrolling credits text starts to high, so it doesn't
fade in...

2. The two globes (about general and about credits) should be at the same
position, currently it looks strange if you click the credits button.
The world image seems to move...

Reproducible: Always
Steps to Reproduce:
1. open about dialog...

Comment 1

[José Jeria]

Can you attach a screenshot and explain what you think is wrong? 
With build;
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040317
Firefox/0.8.0+

I dont see anything wrong.

Comment 2

[Jan aka Elve]

Attachment: Bug1

This shows in which way the text scrolls in (without fading)
if teh text starts farer down, it will fade in due to the about-footer.png
image...

Comment 3

[Jan aka Elve]

Attachment: 2. Bug

This shows the different highs the two globes are on...

Comment 4

[Jan aka Elve]

Attachment: Simple patch

This is a simple patch which fixes the problem with scrolling credits text not
transparent...

Comment 5

[Jan aka Elve]

Attachment: better(?) patch

A more complex patch which also provides more room to the Version Information
Region, such that a longer Vendor comment is displayed correctly...

Additionally i think you shouldn't use differnet sizes for differnet operation
systems (see patch) since you also have to change the corresponding size in
credits.html...

Comment 6

[Jan aka Elve]

Attachment: new about.png

A new about.png based upon the about-credits.png

Comment 7

[Jakob Truelsen]

Attachment: Bug

The bug is still there (In the latest nightly 20050519).. This picture shows
the bug.. and what is should look like (As it looks in thunderbird)
This bug must be easy to fix..

Comment 8

[Jakob Truelsen]

Attachment: A simpel patch

This simple patch fixes the problem 

(patch to chrome/browser.jar/content/browser/credits.xhtml)

Comment 9

[Jakob Truelsen]

Comment on attachment 184097 [details] [diff] [review]
A simpel patch

Index: browser/base/content/credits.xhtml
===================================================================
RCS file: /cvsroot/mozilla/browser/base/content/credits.xhtml,v
retrieving revision 1.9
diff -u -r1.9 credits.xhtml
--- browser/base/content/credits.xhtml	17 Mar 2005 09:41:37 -0000	1.9
+++ browser/base/content/credits.xhtml	21 May 2005 13:42:14 -0000
@@ -87,7 +87,7 @@
	 top: 0px;
	 overflow: hidden;
	 z-index: 1;
-	 height: 285px;
+	 bottom: 10px;
	 width: 280px;
	 margin-left: 10px;
	 margin-right: 10px;
@@ -114,7 +114,7 @@

       h2.title {
	 margin-top: 200px;
-	 margin-bottom: 100px;
+	 margin-bottom: 170px;
	 text-align: center;
       }

Comment 10

[Jakob Truelsen]

Attachment: A real path

Sory.. i dont get this bugzilla thing.. this patch is more decent..

Comment 11

[:Gavin Sharp [email: [e-mail]]]

*** This bug has been marked as a duplicate of 315297 ***