315297 - Credits in about dialog don't scroll and fade in correctly

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Frank Yan (:fryn)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051105 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051105 Firefox/1.5

The credits in the about dialog appear from the middle of the dialog and don't fade in.

Reproducible: Always

Comment 1

[Frank Yan (:fryn)]

add this to userChrome.css to make it display correctly:

#creditsBox {
  height: auto !important;
  bottom: 8px !important;
}
#creditsBox > .title > .motto {
  margin-bottom: 180px !important;
}

Comment 2

[Sébastien Auger]

is it still possible to get this minor riskless fix for 1.5 ?
not a bug, just a better "rendering" of the credits ..

Comment 3

[Shayne Jewers]

Attachment: add userchrome fix from comment 1 to css in credits .xhtml

for both FF and TB

Comment 4

[Aaron Slunt]

There's no need for height: auto; as auto is default.

I'd recommend requesting review from either mconnor or bryner

Comment 5

[Frank Yan (:fryn)]

Asa, could you at least get someone to review my patch so it has a chance of being checked in the trunk once Firefox 1.5 is released?

Comment 6

[Asa Dotzler [:asa]]

I'm sure mconnor will get to the review when he gets done with the more important bugs. 

Comment 7

[Frank Yan (:fryn)]

(In reply to comment #3)
> Created an attachment (id=202027) [edit]
> add the userchrom fix to the css
> 
> for both FF and TB
> 

i know i'm being picky, but you added one too many lines of white space in the patch. notice how there are two lines of white space separating the set of brackets in the first half of the patch.

thanks for making the patch. i wasn't sure where to add my fixes.

proud to contribute my share, however small it may be, to the firefox project.

Comment 8

[Shayne Jewers]

Attachment: Remove un-needed return

whoops, fixed

Comment 9

[Frank Yan (:fryn)]

shayne, are you going to request review from mconner?

no hurry. there's no way this is going to get checked in until Firefox 1.5 is finalized and released, etc.

Comment 10

[Shayne Jewers]

Comment on attachment 202156 [details] [diff] [review]
Remove un-needed return

opps, thought I did

Comment 11

[Frank Yan (:fryn)]

i changed the version to trunk so mconner would more likely review it:

see here:
http://steelgryphon.com/blog/?p=67

Comment 12

[Frank Yan (:fryn)]

I just realized the following:
Firefox 1.5 = Gecko 1.8
Firefox 2.0 = Gecko 1.8.1
Firefox 3.0 = Gecko 1.9

this fix should be checked into both the branch and the trunk.
what should i set the version to?

Comment 13

[Sébastien Auger]

(In reply to comment #12)
> I just realized the following:
> Firefox 1.5 = Gecko 1.8
> Firefox 2.0 = Gecko 1.8.1
> Firefox 3.0 = Gecko 1.9
> 
> this fix should be checked into both the branch and the trunk.
> what should i set the version to?
> 

yeah a lot of people got confused with this. Months ago, I thought we gonna had Firefox 3 on Gecko v2.0 ;-) You should set this to trunk,anyway it can make 1.8.1 even if you set it to trunk.

Comment 14

[Frank Yan (:fryn)]

Attachment: Better patch: Remove un-needed height setting

This patch should make the other attachments obselete.
I have confirmed that "height: auto" is not needed.

Could someone look over this patch and make sure I got the numbers right?

like this thing that you have to add:
@@ -80,26 +80,30 @@

Comment 15

[chris hofmann]

1.8.0.1/ff1.5.1 is for security and stability fixes only.  this would be better in 1.9 and maybe 1.8.1

Comment 16

[Mike Connor [:mconnor]]

Comment on attachment 202156 [details] [diff] [review]
Remove un-needed return

obsoleting in favour of the revision of this patch

Comment 17

[Frank Yan (:fryn)]

(In reply to comment #16)
> (From update of attachment 202156 [details] [diff] [review] [edit])
> obsoleting in favour of the revision of this patch
> 

i put down the wrong person to ask for a review. i meant to put down you. sorry. could you review this?

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/browser/base/content/credits.xhtml; new revision: 1.14;
mozilla/mail/base/content/credits.xhtml; new revision: 1.9;
1.8:
mozilla/browser/base/content/credits.xhtml; new revision: 1.10.4.3;
mozilla/mail/base/content/credits.xhtml; new revision: 1.4.2.3;

Comment 19

[Jakob Truelsen]

Hmm.. this bug is a dublicate of bug 237804.. where to i submitted a patch a long time ago.. close that bug now...

Comment 20

[:Gavin Sharp [email: [e-mail]]]

*** Bug 237804 has been marked as a duplicate of this bug. ***