238033 - Close tags for HTML table in editusers.cgi unnecessary/displaced

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Rudolf Ramler]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.0.3705; .NET CLR 1.1.4322)
Build Identifier: 

In editusers.cgi (in the sub EmitFormElements) there is an unnecessary close 
tag for an HTML table (</TR></TABLE></TD>), and another one seems to be at the 
wrong block; perhaps because the indentation of the closing brackets is a bit 
unusual/mixed. These close tags result in misaligned (customized) layout.

BTW: This bug may become obsolete anyway once a template for editusers.cgi is 
provided (bug #119485).


Reproducible: Always
Steps to Reproduce:

Comment 1

[Rudolf Ramler]

Attachment: Quick patch to editusers.cgi

Some editing at the sub EmitFormElements: Realigned brackets and removed print
statement.

Comment 2

[Vlad Dascalu]

Ugh, pre-templatization code. :-)

Since 2.18 ships these days, I guess this makes sense (with an actual
templatization effort after the 2.18 release).

Comment 3

[Dave Miller [:justdave]]

sure.

Comment 4

[Vlad Dascalu]

Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.51; previous revision: 1.50
done

Comment 5

[Joel Peshkin]

*** Bug 249575 has been marked as a duplicate of this bug. ***