Closed Bug 23844 Opened 26 years ago Closed 25 years ago

:first-letter{float:left;} -> alignment too low

Categories

(Core :: Layout, enhancement, P3)

x86
All
enhancement

Tracking

()

VERIFIED DUPLICATE of bug 21616

People

(Reporter: nikolaus.kuehn, Assigned: pierre)

References

()

Details

(Keywords: css1)

Attachments

(4 files)

To achieve a "classic newspaper/magazine" alignment like it is shown as an example in the w3c css specs one has to use the float:left style. result in mozilla M12: the letter stands a bit too low, looks not nice.
Attached file HTML test code
Assignee: troy → kipp
Summary: {css1}:first-letter{float:left;} -> alignment too low → {css1}:first-letter{float:left;} -> alignment too low
block/inline bug
Keywords: css1
Migrating from {css1} to css1 keyword. The {css1}, {css2}, {css3} and {css-moz} radars should now be considered deprecated in favour of keywords. I am *really* sorry about the spam...
Summary: {css1}:first-letter{float:left;} -> alignment too low → :first-letter{float:left;} -> alignment too low
Hmm. We're actually following the letter of the spec here. But as you say, it is ugly. See also bug 21616, which covers the case of a non-floating first-letter.
I think that bug covers the case of floating first-letter, since it was established that there's nothing to do to the non-floating case without deviating from the spec, but the floating case can be changed. (I think... maybe it covers both.) In any case, I think this could be marked a duplicate of bug 21616.
Target Milestone: M16
mine! mine mine mine! all mine! whoo-hoo!
Assignee: kipp → buster
Attached file A better testcase
Note that this problem is much more visible on Windows than on Mac. On Mac, the 96px letter (at the bottom of the page) is 6 pixels too low. On Windows, it is about 16 pixels too low. Something must be wrong in the text height calculation in WinGFX. Reassigned to Erik who usually kindly volunteers his time on font metrics (if you don't have time, send the bug to <kmcclusk>)
Assignee: buster → erik
*** Bug 32082 has been marked as a duplicate of this bug. ***
I'm certainly willing to look into it, especially since it sounds like there might be a problem down in GFX (since you say the problem is worse on Windows than on the Mac). If the problem was up in layout land, I wouldn't really know where to start looking. However, I feel that first-letter is a relatively rarely used feature, so I would propose to look into it later rather than sooner. Do you agree? Tentatively marking M18.
Status: NEW → ASSIGNED
Target Milestone: M16 → M18
Font measurement issues in GFX should be taken seriously. It may be more than just a problem with :first-letter. I set the TFV to M15 but feel free to move it back.
Target Milestone: M18 → M15
Erik, it looks like we do the measurement correctly but we display the letter using the default font and size. Weird...
Hi Pierre, thanks for looking into it. It sounds like a problem in the layout engine. I've noticed that Kipp kept a number of different fonts lying around, one "normal" one, one for small caps, etc. So maybe he's using the right font for measurement, and the wrong font for drawing? Re-assigning to Pierre for now. Please re-assign to somebody who knows that part of the layout engine (or currently owns it: SteveC?).
Assignee: erik → pierre
Status: ASSIGNED → NEW
I really messed up with that bug: 1) Ignore the last comments and attachments. They are related to bug 32082 that was wrongfully closed as dup of this one. I reopened it. 2) As dbaron reported on 2000-01-20 17:20, the original description of that bug shows that it can be closed as dup of bug 21616. I'm going to move my testcase and some comments over to bug 21616 because they show an additional problem with font measurement and first-letter, especially on Windows. *** This bug has been marked as a duplicate of 21616 ***
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
VERIFY duplicate
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: