23851 - IME-Adding spaces at beginning of line needs two spaces when IME is on

Status: VERIFIED DUPLICATE of bug 43030

(Core :: Internationalization, defect, P3)

Description

[Teruko Kobayashi]

This is related to bug 11994, but this happen at the beginning of the line.

When the spaces are added to the next line, the caret does not move one space bar (need to hit space bar twice) at
the beginning of the next line.

Steps of reproduce
1. Open Composer by selecting menu Task|Composer
2. Turn on the IME by Alt+~ and change the Zenkaku Hiragana mode
3. Hit the Space bar several times until go to the next line
The carret moves fine, but at the beginning of the next line, you need to hit space twice to move one carret.

Tested 2000011108 Win32 build under Winnt4.0J and 2000011208 Win32 build under Win95J.

Comment 1

[rubydoo123]

setting this to m14

Comment 2

[rubydoo123]

m15

Comment 3

[Joe Francis]

fixed, i think.

Comment 4

[Teruko Kobayashi]

This still happen in 2000041009-M15 and 2000041106-M15 Win32 build.

Comment 5

[Kathleen :Brade]

I don't think this is a blocker for M15 so moving to M16

Comment 6

[Joe Francis]

Frank, I cannot reproduce this.  When I try, I get an assert: mIMECompString is 
null, widget/src/windows/nsWindow,cpp line 3675.  I'm assuming you want to look 
at this assert.  This is on NT4.

On mac I dont see either the assert or the problem reported here.

Comment 7

[Joe Francis]

*** Bug 23855 has been marked as a duplicate of this bug. ***

Comment 8

[Frank Tang]

reassign this back to jfrancis.
joe- I can reproduce this under English mode. I think this is a general composer 
issue and nothing do with IME. teruko- am I right ? Can you see the same problem 
under English keyboard ?

Comment 9

[Joe Francis]

ok, i'll look at this some more.  Let me know if you ever see this on anything 
besides windows.  windows only non-IME probs are actually pretty unlikely to be 
editor problems.  Maybe it's another text rendering problem.

Comment 10

[Phil Peterson]

[nsbeta2-]

Comment 11

[Joe Francis]

Something strange is going on here.  The editor is generating the correect 
content, but as soon as you hit enough spaces to get to the next line, your caret 
only moves after every second space.  Type an x or something, and good behavior 
returns until you space to the next line again.  I suspect something is wrong 
with text width measuring a text node wraps across lines.

Steve, can you forward this to the right layout person?

Comment 12

[buster]

PDT- for beta2, so pushing to M18

Comment 13

[Shanjian Li]

The problem is caused by the leading whitespace. It is skipped in 
layout rendering, and that's the right behavior. In oder to keep
those space, editor has function called 
"nsHTMLEditRules::DoTextNodeWhitespace" to handle this. But this
function failed to handle the leading space correctly. Some 
modification in this function will make it work. Fix will be 
posted below.

Comment 14

[Shanjian Li]

Attachment: proposed fix.

Comment 15

[Shanjian Li]

steve, you can reassign the bug to me, I will take care of it.

Comment 16

[buster]

thank you!

Comment 17

[Shanjian Li]

Attachment: Previous has a small problem. This one should be fine.

Comment 18

[Shanjian Li]

Michael, could you review my fix for this bug?

Comment 19

[Shanjian Li]

reassign the bug to mjudge.
Michael,
Please review my fix and check it in if you believe it is OK.

Comment 20

[Shanjian Li]

I just find out that mjudge is not the right owner. 
But the system does not allow me to change it. I may need 
to ask someone help me to do it.

Comment 21

[rubydoo123]

reasigning this back to jfrancis, Joe can you review the patch?

Comment 22

[Joe Francis]

This is a dup of 43030, which I am working on.  I think I have to do more than 
just what is done in the patch here.  I'll make sure I understand what you've 
done and why it works for you... thanks.


*** This bug has been marked as a duplicate of 43030 ***

Comment 23

[Matt Perry]

Verifiy duplicates.

Comment 24

[Teruko Kobayashi]

This is still reproduciable in 2000-09-18-05 Win32 build.  Reopenning.

Comment 25

[rubydoo123]

marking as a dup again -- please do not reopen the bug unless the the dup'ed bug
has been resolved and verified as fixed

this has been marked as a dup of 43030, that has been marked as a dup of 47015.
Bug 47015 is still very much open


*** This bug has been marked as a duplicate of 43030 ***

Comment 26

[Teruko Kobayashi]

Verified.