238765 - Flag inclusions and exclusions not validated

Status: NEW

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Nick Barnes]

User-Agent:       Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.5) Gecko/20031109
Build Identifier: 

The flag type editing code doesn't check that the inclusions and exclusions make
sense, i.e. that there are any components which do allow flags of this type.

An easy demo is to have include "TestProduct:TestComponent" and exclude
"TestProduct:Any".

The question to ask is: are there any inclusions which are not covered by the
exclusions?


Reproducible: Always
Steps to Reproduce:
1. Edit flags -> Create Flag Type for Bugs
2. Remove the __Any__:__Any__ inclusion.
3. Add TestProduct:TestComponent inclusion, TestProduct:Any exclusion
4. Create
Actual Results:  
the flag type is created.

Expected Results:  
Bugzilla either generates an error and pops me back to the "Create Flag Type"
page or generates a warning while going ahead and creating the flag type as
specified.

Comment 1

[Joel Peshkin]

*** Bug 238804 has been marked as a duplicate of this bug. ***

Comment 2

[Frédéric Buclin]

This is not a problem for me. Only products/components which are in the
inclusion list but not in the exclusion list have this flag type displayed. In
your case, this means that this flag type is not displayed at all. It looks like
a good way to me to remove all flags of this type at once! :)

myk, what do you want to do with this bug? Note that there is no warning about a
potential flags deletion. A message such as "14 flags of this type will be
deleted if you confirm these changes. Are you sure you want to continue?" would
be appreciated here. But maybe this is another bug.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

> It looks like a good way to me to remove all flags of this type at once!

Yes, we shouldn't make this impossible, but we should find a way to show the
user the result of her inclusions and exclusions so that she can change it if it
doesn't make sense.  Perhaps we can add a third column which shows the list of
product/component combos for which the flag type will be valid given the items
on the two clusions lists.

> myk, what do you want to do with this bug?

It's a valid issue, although it's not a bug.  Confirming and triaging to
"enhancement".

> Note that there is no warning about a potential flags deletion. A message 
> such as "14 flags of this type will be deleted if you confirm these changes.
> Are you sure you want to continue?" would be appreciated here. But maybe
> this is another bug.

Yup, I have filed it as bug 288537.