Make sure detaint_natural is always called with a defined value in editkeywords.cgi

RESOLVED FIXED in Bugzilla 2.18

Status

()

task
P1
trivial
RESOLVED FIXED
15 years ago
7 years ago

People

(Reporter: goobix, Assigned: goobix)

Tracking

unspecified
Bugzilla 2.18
Bug Flags:
approval +
blocking2.18 +

Details

Attachments

(1 attachment)

Assignee

Description

15 years ago
We messed up with this one :-)
Assignee

Comment 1

15 years ago
Posted patch PatchSplinter Review
Assignee

Updated

15 years ago
Status: NEW → ASSIGNED
Flags: blocking2.18?
Flags: approval?
Assignee

Updated

15 years ago
Target Milestone: --- → Bugzilla 2.18
Assignee

Updated

15 years ago
Attachment #145414 - Flags: review?(kiko)
Assignee

Updated

15 years ago
Severity: normal → trivial
Priority: -- → P1
Assignee

Updated

15 years ago
Attachment #145414 - Flags: review?(justdave)
Assignee

Updated

15 years ago
Attachment #145414 - Flags: review?(timeless)

Updated

15 years ago
Attachment #145414 - Flags: review?(timeless) → review+
Assignee

Updated

15 years ago
Attachment #145414 - Flags: review?(kiko)
Attachment #145414 - Flags: review?(justdave)
doh
Flags: blocking2.18?
Flags: blocking2.18+
Flags: approval?
Flags: approval+
Assignee

Comment 3

15 years ago
Checking in editkeywords.cgi;
/cvsroot/mozilla/webtools/bugzilla/editkeywords.cgi,v  <--  editkeywords.cgi
new revision: 1.22; previous revision: 1.21
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

Comment 4

15 years ago
For reference, this was a regression from bug 234175; sorry for not catching
that in review. grep tells me we don't have any more of these cases left in the
tree.
That bug didn't touch those lines, I think you must mean bug 234879?

Comment 6

15 years ago
Doh, yeah.
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.