Closed
Bug 239576
Opened 22 years ago
Closed 22 years ago
Make sure detaint_natural is always called with a defined value in editkeywords.cgi
Categories
(Bugzilla :: Administration, task, P1)
Bugzilla
Administration
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: goobix, Assigned: goobix)
Details
Attachments
(1 file)
|
497 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
We messed up with this one :-)
| Assignee | ||
Comment 1•22 years ago
|
||
| Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Flags: blocking2.18?
Flags: approval?
| Assignee | ||
Updated•22 years ago
|
Target Milestone: --- → Bugzilla 2.18
| Assignee | ||
Updated•22 years ago
|
Attachment #145414 -
Flags: review?(kiko)
| Assignee | ||
Updated•22 years ago
|
Severity: normal → trivial
Priority: -- → P1
| Assignee | ||
Updated•22 years ago
|
Attachment #145414 -
Flags: review?(justdave)
| Assignee | ||
Updated•22 years ago
|
Attachment #145414 -
Flags: review?(timeless)
Attachment #145414 -
Flags: review?(timeless) → review+
| Assignee | ||
Updated•22 years ago
|
Attachment #145414 -
Flags: review?(kiko)
Attachment #145414 -
Flags: review?(justdave)
Comment 2•22 years ago
|
||
doh
Flags: blocking2.18?
Flags: blocking2.18+
Flags: approval?
Flags: approval+
| Assignee | ||
Comment 3•22 years ago
|
||
Checking in editkeywords.cgi;
/cvsroot/mozilla/webtools/bugzilla/editkeywords.cgi,v <-- editkeywords.cgi
new revision: 1.22; previous revision: 1.21
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 4•22 years ago
|
||
For reference, this was a regression from bug 234175; sorry for not catching
that in review. grep tells me we don't have any more of these cases left in the
tree.
Comment 5•22 years ago
|
||
That bug didn't touch those lines, I think you must mean bug 234879?
Comment 6•22 years ago
|
||
Doh, yeah.
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•