Closed Bug 239576 Opened 21 years ago Closed 21 years ago

Make sure detaint_natural is always called with a defined value in editkeywords.cgi

Categories

(Bugzilla :: Administration, task, P1)

Product:
Bugzilla
Component:
Administration
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.18

People

(Reporter: goobix, Assigned: goobix)

Details

Attachments

(1 file)

Patch
497 bytes, patch
timeless
: review+
Details | Diff | Splinter Review
We messed up with this one :-)
Attached patch Patch — — Splinter Review
Status: NEW → ASSIGNED
Flags: blocking2.18?
Flags: approval?
Target Milestone: --- → Bugzilla 2.18
Attachment #145414 - Flags: review?(kiko)
Severity: normal → trivial
Priority: -- → P1
Attachment #145414 - Flags: review?(justdave)
Attachment #145414 - Flags: review?(timeless)
Attachment #145414 - Flags: review?(timeless) → review+
Attachment #145414 - Flags: review?(kiko)
Attachment #145414 - Flags: review?(justdave)
doh
Flags: blocking2.18?
Flags: blocking2.18+
Flags: approval?
Flags: approval+
Checking in editkeywords.cgi; /cvsroot/mozilla/webtools/bugzilla/editkeywords.cgi,v <-- editkeywords.cgi new revision: 1.22; previous revision: 1.21 done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
For reference, this was a regression from bug 234175; sorry for not catching that in review. grep tells me we don't have any more of these cases left in the tree.
That bug didn't touch those lines, I think you must mean bug 234879?
Doh, yeah.
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: