240238 - Crash in XRemoteClient on startup

Status: VERIFIED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This crash doesn't happen every time, but often enough; I've finally managed to
catch it in a debug build.  This looks like fallout from bug 237283; it also
looks like bryner's patch in bug 240174 might fix it, maybe.

To reproduce, just start the browser.  It's not consistent, unfortunately... 
most of the time the browser just sends there for 2-3 seconds doing nothing,
then does the stuff in bug 240174.

Debug info follows:

#4  <signal handler called>
#5  0x4057c583 in strlen () from /lib/libc.so.6
#6  0x40120caa in XRemoteClient::DoSendCommand(unsigned long, char const*,
char**, int*)
    (this=0x81153e8, aWindow=27905236, aCommand=0x0, aResponse=0xbffff368, 
    aDestroyed=0xbffff328)
    at
/home/bzbarsky/mozilla/xlib/mozilla/widget/src/xremoteclient/XRemoteClient.cpp:550
#7  0x4012019d in XRemoteClient::SendCommand(char const*, char const*, char
const*, char const*, char**, int*) (this=0x81153e8, aProgram=0x8081bc6 "mozilla", 
    aUsername=0xbffffe88 "bzbarsky", aProfile=0x0, aCommand=0x0,
aResponse=0xbffff368, 
    aWindowFound=0xbffff364)
    at
/home/bzbarsky/mozilla/xlib/mozilla/widget/src/xremoteclient/XRemoteClient.cpp:155
#8  0x08064335 in HandleRemoteArguments (argc=1, argv=0xbffff464,
aArgUsed=0xbffff3e8)
    at /home/bzbarsky/mozilla/xlib/mozilla/xpfe/bootstrap/nsAppRunner.cpp:1497

(gdb) frame 6
#6  0x40120caa in XRemoteClient::DoSendCommand(unsigned long, char const*,
char**, int*)
    (this=0x81153e8, aWindow=27905236, aCommand=0x0, aResponse=0xbffff368, 
    aDestroyed=0xbffff328)
    at
/home/bzbarsky/mozilla/xlib/mozilla/widget/src/xremoteclient/XRemoteClient.cpp:550
550       XChangeProperty (mDisplay, aWindow, mMozCommandAtom, XA_STRING, 8,
(gdb) list 550,552
550       XChangeProperty (mDisplay, aWindow, mMozCommandAtom, XA_STRING, 8,
551                        PropModeReplace, (unsigned char *)aCommand,
552                        strlen(aCommand));
(gdb) p aCommand
$4 = 0x0

Comment 1

[Christopher Blizzard (:blizzard)]

tenatively marking fixed.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yeah, I haven't really seen this since the patch for bug 240174 went in.