240695 - Wrong help text: Profile Manager can't be invoked from OS X's finder

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Daniel Küstner]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6a) Gecko/20031020
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6a) Gecko/20031020

Help -> Managing Profiles -> Creating a new profile states:

"2. Open the profile manager:
    [...]
    o On Mac OS open the Mozilla folder and then double-click the Profile Manager"

There is no Mozilla folder on OS X. Mozilla comes as an Application, which in
fact is a directory, but this is not directly visible in the Finder. Even if you
manage to open the Application directory (which is not Mac-like) with Finder's
context menu or in the terminal, there is no Profile Manager executable.

The only way to start the profile manager is to manually invoke
Mozilla.app/Content/MacOS/mozilla-bin -P
in the terminal or to start it from within mozilla.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Daniel Wang]

Does Ctrl+Double Click on app icon work? Also try Cmd and Alt key combo.

Comment 2

[Daniel Küstner]

Daniel: Do you know anything or are you guessing? 

This bug is not on how to invoke the Profile Manager (which is AFAIK only
possible from the command line or from within Mozilla), but on the wrong text in
the online help.

I thought, this should be clear from the component, but I am also changing
summary now.

Comment 3

[Daniel Wang]

I remember seeing somewhere that to open Netscape 7 Profile Manager, you hold
down some control key and double click the icon in Dock. As I don't use Mac OS X
and we don't have many OS X QAs, I can't verify anything, so more information helps.

Comment 4

[Daniel Küstner]

HEUREKA! Alt + single click on the Mozilla item in the dock starts Profile
Manager, but only if Mozilla is not running yet. If Mozilla is running, Alt +
single click hides Mozilla.

This should go into End User Help.

Comment 5

[R.J. Keller]

stefan_h should be able to help with this bug.

Comment 6

[Stefan [:stefanh]]

(In reply to comment #4)
> HEUREKA! Alt + single click on the Mozilla item in the dock starts Profile
> Manager, but only if Mozilla is not running yet.

Yes, this was introduced with the fix for bug 194149. Option (== Alt) +
double-click on the Mozilla app should work as well. However, I doesn't work for
me with Mozilla 2004040505 on Mac os 10.2.8 

Comment 7

[R.J. Keller]

Attachment: Patch

Comment 8

[R.J. Keller]

Attachment: Patch with correct text

stefan_h told me that I had the wrong text, so this is the right method for
opening the profile manager :).

Comment 9

[Daniel Küstner]

Sorry, but this text is wrong for Mac OS. There is no Mozilla folder and Alt +
Doubleclick on the Mozilla-Icon in the Application folder just starts Mozilla.
The only method which works, is Alt + Click on the Mozilla icon in the dock.
This only works, if Mozilla isn't started yet. So the text should be something like:

"If you have Mozilla in the dock, you can start the profile manager with Alt +
Click. This only works, when Mozilla is closed. You can invoke profile manager
also from Tools -> Switch Profile -> Manage Profiles..."

Comment 10

[Stefan [:stefanh]]

> Sorry, but this text is wrong for Mac OS. There is no Mozilla folder and Alt +
> Doubleclick on the Mozilla-Icon in the Application folder just starts Mozilla.
> The only method which works, is Alt + Click on the Mozilla icon in the dock.

Ah, of course it should be Mozilla icon in the Applications folder - sorry
Keller I didn't pay enough attention. Strange that it doesn't work, though. Bug
194149 should have fixed that. But I can't verify that it works since none of
the variants works for me. It might be my build, though. Daniel K: what version
of Mozilla and mac os are you using?

Comment 11

[Daniel Küstner]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040316
and OS X 10.3.3

Comment 12

[Stefan [:stefanh]]

Ah, both methods works for me now with Mozilla 2004041708. 

Comment 13

[[e-mail]]

Comment on attachment 146322 [details] [diff] [review]
Patch with correct text

I'll assume that the mouse combo you have is correct (is it really called Alt
on the Mac?), but it is in fact possible to create a new profile while the
browser is running, as bug 97622 was fixed over a year ago. You should
therefore remove the <li>Exit the browser...</li> and insert a line into the
sublist <li>If the browser is running, then from the Tools menu, select Switch
Profile.</li> and prepend Otherwise, to each of the platform-specific lines.

Comment 14

[Stefan [:stefanh]]

Keller: you can assign this to me (if you want). Just going to find out which
mac key (Alt or Option) that's most common...

Comment 15

[Stefan [:stefanh]]

Since I have an Alt key on my mac keyboard I haven't realized until now how
unusual it is. After talking to pinkerton on irc and looked at Apples website
I'm convinced that we should use "Option" instead of "Alt".

Comment 16

[Stefan [:stefanh]]

--> me.

Comment 17

[Stefan [:stefanh]]

Attachment: New Patch with correct mac key and new text

This patch include the right mac key and has some new text as well. Used <span>
instead.

Comment 18

[Stefan [:stefanh]]

Comment on attachment 147061 [details] [diff] [review]
New Patch with correct mac key and new text

Asking neil since Keller asked him... BTW - there shouldn't be any mac
linebreaks in the patch :)

Comment 19

[Stefan [:stefanh]]

Filed bug 241806 - to change the mentioned Alt key to Option in shortcuts.xhtml

Comment 20

[[e-mail]]

Comment on attachment 147061 [details] [diff] [review]
New Patch with correct mac key and new text

Hmmm... does the <span> stuff only work on the xhtml?

Comment 21

[Stefan [:stefanh]]

> Hmmm... does the <span> stuff only work on the xhtml?

Heh, both files uses the old stylesheet: chrome://help/locale/content_style.css

I am at work now - will fix that later.

Comment 22

[Stefan [:stefanh]]

Attachment: corrected patch, with @import platformClasses.css in the stylesheet

Added @import url("chrome://help/content/platformClasses.css"); to the old
stylesheet that these files are using. Should work now (and shouldn't break
anything in the other files). This file will use the new stylesheet soon - will
take care of that in  bug 236942.

Comment 23

[[e-mail]]

Comment on attachment 147239 [details] [diff] [review]
corrected patch, with @import platformClasses.css in the stylesheet

Should we get the change to rename and delete exactly correct? You can't rename
or delete the running profile but you can rename or delete other profiles, or
if you start up with the profile manager.

You're also missing some indentation on some of your <li> lines, it should look
like this.
<ol>
  <li>...</li>
  <ul>
    <li>...</li>
    <li>...</li>
  </ul>
  <li>...</li>
</ol>

And your patch doesn't end in a newline :-P

Comment 24

[Stefan [:stefanh]]

> Should we get the change to rename and delete exactly correct? You can't rename
> or delete the running profile but you can rename or delete other profiles, or
> if you start up with the profile manager.

That's a good idea! Will fix that in a few days. Getting late here (CET) :)

> You're also missing some indentation on some of your <li> lines, it should look
> like this.
> <ol>
>   <li>...</li>
>   <ul>
>     <li>...</li>
>     <li>...</li>
>   </ul>
>   <li>...</li>
> </ol>

Err, so far I've been doing like this:

<----80 characters---->
<ol>
   <li>...............
     </li>
   <ul>
     <li>.............
       </li>
     <li>.............
       </li>
   </ul>
   <li>...............
     </li>
</ol>

Comment 25

[[e-mail]]

Well your patch says
<ol>
<li>...</li>
  <ul>
    <li>...</li>
etc.

Comment 26

[Stefan [:stefanh]]

Attachment: New version of the patch

Fixed the indentation and added a note that you can't delete the profile that
is in use. Actually, you can rename a running profile, just did that with my
20040417 build :)

Comment 27

[Stefan [:stefanh]]

Comment on attachment 147405 [details] [diff] [review]
New version of the patch

I hope I have a newline. Didn't really see/understood the problem. 
profiles_help.html will be converted to xhtml by me in a week or so. Just
realized that i forgot to do the diff for the file with xhtml-suffix. Do you
need that too?

Comment 28

[[e-mail]]

Comment on attachment 147405 [details] [diff] [review]
New version of the patch

>+    &quot;School.&quot;</li>
This got me confused; who'd want to put a decimal point in their profile name?
(Is it even legal?) But then I realized this is a full stop, and it got tucked
inside the quote marks as if it was speech. Sigh...

>-<p>The opening screen of the Profile Manager reappears, with the new profile listed and highlighted. 
>+<p>The opening screen of the Profile Manager reappears, with the new profile
>+  listed and highlighted.</p>
I'm also confused as to what the original author meant by the opening screen;
as far as I know the Profile Manager only has one screen.

>-	<li>To delete a profile, select its name and click Delete Profile.
This line got lost ;-) Otherwise this has r=me. It might be worth explaining
the confirmation prompt, but I'd check with the module owner first.

Comment 29

[Stefan [:stefanh]]

Attachment: New version with fixed quote mark and the missing "To delete..." line

Sorry about that missing line ;) 

> I'm also confused as to what the original author meant by the opening screen;

> as far as I know the Profile Manager only has one screen.

It does makes sense to me. But i guess "screen" isn't really 100% correct?

Comment 30

[R.J. Keller]

> This line got lost ;-) Otherwise this has r=me. It might be worth explaining
> the confirmation prompt, but I'd check with the module owner first.

Yes, I would like this confirmation prompt explained. It is a bit confusing for
beginning users.

Comment 31

[Stefan [:stefanh]]

Attachment: New version with confirmation prompt explained

This version explains the confirmation promt. I also removed the sentence with
"The opening screen of the...". The list (Deleting or renaming a profile) has
only two main sections now instead of 3.

Comment 32

[Stefan [:stefanh]]

Comment on attachment 147922 [details] [diff] [review]
New version with confirmation prompt explained

Neil, I'm not sure if I should ask you again. If you feel that this is rlk:s,
please just change the Requestee or add a comment :)

Comment 33

[[e-mail]]

Comment on attachment 147922 [details] [diff] [review]
New version with confirmation prompt explained

>+  <li style="list-style-type: none;">To rename a profile, select its name,
>+    click Rename Profile, and follow the instructions.</li>
What's the point of the list-style-type here? If the item looks odd here, try
moving it above the delete item.

Comment 34

[Stefan [:stefanh]]

> >+  <li style="list-style-type: none;">To rename a profile, select its name,
> >+    click Rename Profile, and follow the instructions.</li>
> What's the point of the list-style-type here? If the item looks odd here, try
> moving it above the delete item.

Without the list-style-type it would look like this:

1. Open the PM
2. To delete a profile....
3. To rename a profile...

In creating a profile (section above) its ok, since you should do all the steps,
but in here you would only do two steps.

So, I thought it would be more logical to have it like this:

1. Open the PM
2. To delete a profile...
   To rename a profile... 

Comment 35

[[e-mail]]

Then maybe it would be better to change the <ol> to a <ul>?

Comment 36

[Stefan [:stefanh]]

Attachment: Corrected version

This version puts the "To rename a Profile..." in the same <li> as the "To
delete a profile..." as suggested by Neil on irc

Comment 37

[Stefan [:stefanh]]

Attachment: Final version

Neil pointed out some errors for me on irc. This is (hopefully) the final
version.

Comment 38

[Stefan [:stefanh]]

Attachment: Diff for profiles_help.xhtml

Here's the diff for the .xhtml version of profiles help.

Comment 39

[R.J. Keller]

Fix checked in.