240704 - [Mac] commonDialog (ex."warn leaving secure") is trimmed in certain fonts and strings

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Takanori MATSUURA]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040415 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040415 Firefox/0.8.0+

When leaving the secure (https) site, message in "warn leaving secure" dialog is
not wrapped on Mac OS X.

Reproducible: Always
Steps to Reproduce:
1. visit https site
2. leave https site
3. check the dialog window

Actual Results:  
Message is NOT wrapped at the end of the dialog.

Expected Results:  
Message is wrapped at the end of the dialog.

Comment 1

[Takanori MATSUURA]

Attachment: Screen shot

Screen shot of "warn leaving secure" dialog.

Comment 2

[Bruce Davidson]

This works for me using a recent nightly from the trunk. Can you check in a
recent nightly and see whether this is still a problem or not.

Comment 3

[Hiro]

A problem may occur depending on a setup of the used language of OS.
(By the case of bug233752, the trifling problem has occurred in the bookmark
tool bar.)
When the following contents are added to a userChrome.css file, does a problem fix?

   Contents added to userChrome.css:

   * {
       font-family: "Lucida Grande", sans-serif !important;
   }

When a problem fixes by this customize, depending on a language setup used by
OS, the problem similar to these regards me as still generating in other scenes.
This is not good when using languages other than English (when Japanese is being
used at least).

Comment 4

[HARUNAGA Hirotoshi]

Reproduced with Mac Firefox in Japanese locale.
Mac Firefox in English locale and Mozilla App suite in Japanese locale
don't have this problem.
Probably related to Bug 233781, but the tip in comment 3 doesn't work
in this case.

Marking New.

Comment 5

[HARUNAGA Hirotoshi]

Attachment: screenshot (English locale vs Japanese locale)

Comment 6

[HARUNAGA Hirotoshi]

The dialog width is too narrow in Japanese locale.
Seems like max-width: 40em of #commonDialog is enough for Lucida Grande,
but not for Hiragino font.

Workaround using userChrome.css:

#commonDialog { font-family: "Lucida Grande" !important; }
#commonDialog > hbox > vbox > description,
#commonDialog > hbox > vbox > vbox > description {
  font: bold 13px/16px "Lucida Grande" !important;
}
#checkboxContainer {
  font-size: 11px;
  line-height: 13px;
}

changing the summary and making dependency on Bug 233781.

Comment 7

[dynamis (Tomoya ASAI)]

As a workaround about this I included #6 css rule into intl.css of ja-JPM
http://lxr.mozilla.org/l10n-aviarybranch/source/toolkit/locales/ja-JPM/chrome/global/intl.css
This workaround is not good solution and cannot be used other loacle because this
css rule should be used only in Mac.

c.f.
Russian Mac have similar problem (Bug 267989).
They cannot do same as japanese because they don't have separate tree of l10n cvs.

Comment 8

[HARUNAGA Hirotoshi]

intl.css in Firefox 1.0 ja-JPM doesn't work because other css rules are included
together.

Comment 9

[HARUNAGA Hirotoshi]

Dom Inspector shows as follows:

In English locale:
#commonDialog
 font-family: Lucida Grande
 font-size: 11px
 max-width: 440px
 min-width: 319px
 width: 504px     <- see

In Japanese locale:
#commonDialog
 font-family: Hirahigo Kaku Go Pro
 font-size: 11px
 max-width: 440px
 min-width: 319px
 width: 413px

So max-width 40em of #commonDialog is not correct.
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/global/global.css#142
It should be 48em at least (or it should be removed).

Comment 10

[HARUNAGA Hirotoshi]

Attachment: patch

Comment 11

[:Gavin Sharp [email: [e-mail]]]

*** Bug 266285 has been marked as a duplicate of this bug. ***

Comment 12

[HARUNAGA Hirotoshi]

Attachment: patch2 (613px)

#commonDialog > xul:vbox > hbox > vbox has 45em (495px) as max-width.
.alert-icon has width:64px; margin-left:6px; margin-right:20px.
<dialog> has padding:14px.
So max-width for #commonDialog should be 613px (56em) if it's specified.

I recommend removing it.

Comment 13

[HARUNAGA Hirotoshi]

Changing the summary.

Comment 14

[HARUNAGA Hirotoshi]

*** Bug 267989 has been marked as a duplicate of this bug. ***

Comment 15

[HARUNAGA Hirotoshi]

Comment on attachment 166654 [details] [diff] [review]
patch2 (613px)

613px is too big.

Comment 16

[HARUNAGA Hirotoshi]

Attachment: patch3 (437px or more)

Comment 17

[HARUNAGA Hirotoshi]

max-width:45em for the inner vbox is specified in commonDialog.xul that
is shared by all platforms.
It's necessary to remove max-width:40em for #commonDialog and overwrite
max-width:30em for the inner vbox in global.css, I think.

The problem is solved on the following builds at least if the patch is applied.
- English build in Japanese locale
- Italian build in Italian locale
- Russian build in English locale

Comment 18

[Asaf Romano (gone)]

Comment on attachment 166774 [details] [diff] [review]
patch3 (437px or more)

as this is a theme fix, you should ask kevin gerich for r= (webmail AT kmgerich
DOT com)

Comment 19

[Kevin Gerich]

Comment on attachment 166774 [details] [diff] [review]
patch3 (437px or more)

please change the max-width to 33em. otherwise +. Would you like me to check
this in?

Comment 20

[HARUNAGA Hirotoshi]

Yes, please check it in.

Comment 21

[Hiro]

*** Bug 279077 has been marked as a duplicate of this bug. ***

Comment 22

[Kevin Gerich]

checked in

Comment 23

[Kevin Gerich]

checked in

Comment 24

[Hiro]

The same problem as Mozilla suite exists. 
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.6) Gecko/20041231