241490 - Calendar build 2004-04-08 w/ Mozilla 1.7rc1 does not fire alarms

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Larry Cook]

User-Agent:       Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.7b) Gecko/20040421
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.7b) Gecko/20040421

I installed Mozilla 1.7rc1 and then installed Calendar build 2004-04-08. 
Existing, as well as new, events do not fire alarms.  Or at least I don't get
any dialog popup like I had been getting with 1.7b and whatever build of
Calendar was available at that time.

Reproducible: Always
Steps to Reproduce:
1. Install 1.7rc1
2. Install Calendar build 2004-04-08
3. Create an event and check "Alarm"

Actual Results:  
When the alarm time has arrived, no notification occurs.

Expected Results:  
Expected an alarm notification dialog to popup.

Comment 1

[Larry Cook]

*** Bug 241491 has been marked as a duplicate of this bug. ***

Comment 2

[Eric Belhaire]

It works for me with :
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040421

Could somebody else confirm this bug ?

Comment 3

[Larry Cook]

Thanks to Eric Belhaire's suggestion, I started the JavaScript Console and saw
the following error:

Error: invalid 'in' operand
Source File: chrome://calendar/content/calendar.js
Line: 211

Line 211 is:

   if( ("arguments" in window) && ("channel" in window.arguments[0]) )

I unzipped calendar.jar, commented out this if statement, and rezipped
calendar.jar.  Now alarms are working.

And ideas on why I would be getting this JavaScript error and not others?  

I'm running on NT4.0, while Eric is using NT5.1 and not seeing the problem. 
Could it be an NT4.0 specific problem?

Comment 4

[Mostafa Hosseini]

This has been fixed :
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=calendar.js&branch=&root=/cvsroot&subdir=mozilla/calendar/resources/content&command=DIFF_FRAMESET&rev1=1.122&rev2=1.123

but the fix will be available in a newer xpi build.

Comment 5

[Larry Cook]

Mostafa, thanks for the pointer to the fix.  I have made the same change to my
calendar.js and it works!  I appreciate your quick response.

Comment 6

[Frank Wein [:mcsmurf]]

Attachment: Patch for this

Comment 7

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!