Closed
Bug 241637
Opened 21 years ago
Closed 19 years ago
Ctrl+P doesn't work in Print Preview
Categories
(Firefox :: Keyboard Navigation, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha2
People
(Reporter: jruderman, Assigned: pilgrim)
References
Details
(Keywords: access, fixed1.8.1)
Attachments
(1 file)
|
1.47 KB,
patch
|
mconnor
:
review+
asaf
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040423
Firefox/0.8.0+
Steps to reproduce:
1. Print Preview.
2. Ctrl+P.
Result: Nothing happens.
Expected: Print dialog.
Works correctly in Seamonkey.
|
||
Updated•21 years ago
|
Assignee: firefox → aaronleventhal
Component: Menus → Keyboard Navigation
QA Contact: bugzilla → jruderman
|
||
Updated•20 years ago
|
Keywords: helpwanted
|
||
Comment 2•19 years ago
|
||
did this ever work in FF?
is this a core bug?
re: SM, it isn't working in current nightlies - eg 20050917 - possible regression?
|
Assignee | |
Comment 3•19 years ago
|
||
Patched PrintUtils.onKeyPressPP to catch Ctrl+P. Actually, it looks for the print menu item and takes the key from there, and checks if it matches with the pressed key.
Attachment #212133 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•19 years ago
|
Assignee: aaronleventhal → pilgrim
|
||
Comment 4•19 years ago
|
||
Comment on attachment 212133 [details] [diff] [review]
Patch to make Control+P print in preview window
this seems strange, but it's printUtils.js, so I'm not going to think about refactoring ;)
Attachment #212133 -
Flags: review?(mconnor) → review+
|
||
Comment 5•19 years ago
|
||
Comment on attachment 212133 [details] [diff] [review]
Patch to make Control+P print in preview window
Checked this in on the trunk.
mozilla/toolkit/components/printing/content/printUtils.js 1.25
Attachment #212133 -
Flags: approval-branch-1.8.1?(mconnor)
|
|
||
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: helpwanted
OS: Windows XP → All
QA Contact: jruderman → keyboard.navigation
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 2 alpha2
Version: unspecified → 2.0 Branch
|
||
Comment 6•19 years ago
|
||
Comment on attachment 212133 [details] [diff] [review]
Patch to make Control+P print in preview window
a181=mano.
Attachment #212133 -
Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
|
|
||
Updated•19 years ago
|
Whiteboard: [checkin needed]
|
|
||
Comment 7•19 years ago
|
||
mozilla/toolkit/components/printing/content/printUtils.js 1.17.10.6
Keywords: fixed1.8
Whiteboard: [checkin needed]
|
|
||
Updated•19 years ago
|
Keywords: fixed1.8 → fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•