281932 - Print preview UI not keyboard accessible

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect, P3)

Description

[Aaron Leventhal]

The print preview screen has a row of controls at the top. They should be in the
tab order along with the print preview pane itself. More mnemonics should also
be added, but the tab key should also be operable here.

Note to QA/testers: once this is fixed please make sure that bug 250096 does not
come back up again.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

All toolbar buttons are keyboard inaccessible, right? Is making them regular
buttons the only solution in cases like these?

Comment 2

[Aaron Leventhal]

(In reply to comment #1)
> All toolbar buttons are keyboard inaccessible, right? Is making them regular
> buttons the only solution in cases like these?

At the moment, yes.

Comment 3

[Aaron Leventhal]

Attachment: Fix missing accesskeys, labels without control attribute which affects accessible name, unfocusable toolbarbuttons

This adds toolbarbutton class="tabbable"

We also needed this for the download manager so I fixed that there too.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 190571 [details] [diff] [review]
Fix missing accesskeys, labels without control attribute which affects accessible name, unfocusable toolbarbuttons

>+++ toolkit/mozapps/downloads/content/downloads.xul 26 Jul 2005 16:33:43 -0000
>@@ -174,11 +174,11 @@
>   
>   <hbox>
>     <hbox id="commandBar" flex="1">
>       <hbox align="center" flex="1" id="autodownloadInfo">
>         <label>&filesSavedTo.label;</label>
>-        <toolbarbutton id="saveToFolder" crop="right" flex="1"
>+        <toolbarbutton class="tabbable" id="saveToFolder" crop="right" flex="1"
>                        oncommand="onDownloadShowFolder();"
>                        tooltiptext="&showFolder.label;"/>
>       </hbox> 
>       <spring id="autodownloadSpring" hidden="true" flex="1"/>
>       <separator id="commandBarSeparator"/> 

you know, it's not possible to tab to this button from the downloads UI now,
but we might as well do this anyway...

Comment 5

[Asaf Romano (gone)]

please land this bit into pinstripe as well

Comment 6

[Asaf Romano (gone)]

I'll file a separate bug on Pinstripe changes, not a blocker now.

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381