242068 - Chatzilla does not resolve non-ascii characters correctly in the URL.

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Thomas Rebtun]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Im not able to use ÆØÅæøå in channel names.
If i join a channel in chatzilla it shows the correct name of the channel , but
i always get this type of URL
irc://irc.homelien.no/osteh%c3%b8vel
When it should be
irc://irc.homelien.no/ostehøvel

Other people cant invite you to their channels eighter if they have ø,æ or å in
them.

Reproducible: Always
Steps to Reproduce:
1. After installing latest chatzilla client 0.9.63a i type
irc://irc.homelien.no/ostehøvel.In the Firefox browser URL box.
This error is consistent in the previous releases of chatzilla also.
2. Sent invite from mIRC #ostehøvel to my chatzilla user and I dont join the
correct channel when i accept the invite. 

Actual Results:  
result of 1st step: This will make you join a channel , but not the correct one,
though the display name inside the irc client is correct. URL is wrong it shows
instead irc://irc.homelien.no/osteh%c3%b8vel
result of 2nd step: You join this channel instead #ostehøvel URL is also wrong
it shows irc://irc.homelien.no/osteh%c3%83%c2%b8vel

Expected Results:  
The software should have been able to resolve the ÅØÆåøæ into the correct
channel names.

This bugg seems to be consistent through out all settings and themes.
This error renders the chatzilla extension to firefox unusable for many users.

Comment 1

[James Ross]

The URL irc://irc.homelien.no/osteh%c3%b8vel is correct. URLs cannot contain the
characters in the channel name, and get escaped based on the UTF-8 representation.

By default ChatZilla sends channel names using the UTF-8 encoding. If the server
you are using does *not* use UTF-8 you *will* need to tell ChatZilla this. It is
impossible for ChatZilla to guess.

I do seem to be having problems joining the channels, though. I will have a look
at this.

Comment 2

[len19.mun]

Attachment: NOT A WIN32 APPLICATION

WILL NOT ALLOW DOWNLOAD OF VIAVOICE

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 179510 [details]
NOT A WIN32 APPLICATION

I don't see what the point of an approval request for a screenshot is.

Comment 4

[Samuel Sieb]

Isn't this just a charset issue?  Since you're most likely dealing with mirc users, change the network/server charset to whatever they're using and it should work.

Comment 5

[James Ross]

There is a bit more to it than charsets; when we get an invite, we MUST be able to join the correct channel for the invite, even if we're in the wrong charset (which will mean we display the channel name incorrectly, but nothing more).

Comment 6

[Stephanie Daugherty [:sdaugherty]]

Changing to confirmed, based on comments there's enough to say theres an issue.

Comment 8

[:Gijs (out for now; he/him)]

Attachment: Patch

This fixes invite URLs. It does a couple of things:

- Use inline buttons to get a full URL instead of just a channel name (which would always be incomplete info, which means we lose if we don't have the correct charset)
- make cmdJoin work if you give it a channel object to join, using only the encodedName for sending stuff to the server, which then means things Just Work.
- make x-cz-command properly escape things (unescape from the x-cz-command URL, then js toSource so it evaluates to a string which is passed to view.dispatch, then escape so it's a javascript: URI)
- make gotoIRCURL use the object variant of /join


We should probably make /query do the same as join, though that's less of a priority as most servers will prevent people from having non-ascii nicks.

Then, as Silver suggested on IRC, we need a general audit of usage of unicodeName where we should really be using the methods on objects or encodedName instead, so we keep the correct references.

Comment 9

[James Ross]

Comment on attachment 302357 [details] [diff] [review]
Patch

>+        var commandStr = decodeURI(ary[1]).toSource();

Please use .quote() here, as discussed on IRC.

>+        var jsStr = "void(view.dispatch(" + commandStr + ", null, true))";
>+        var jsURI = "javascript:" + encodeURI(jsStr)

Nit: missing semi-colon.

Comment 10

[:Gijs (out for now; he/him)]

(In reply to comment #8)
> Then, as Silver suggested on IRC, we need a general audit of usage of
> unicodeName where we should really be using the methods on objects or
> encodedName instead, so we keep the correct references.
> 

I filed bug 416966 for this issue.

Comment 11

[:Gijs (out for now; he/him)]

And this is now checked in, so, FIXED. :-)